Page MenuHomeFreeBSD

libpfctl: fix creatorid endianness
ClosedPublic

Authored by kp on Jan 21 2022, 5:36 PM.
Tags
None
Referenced Files
F105779370: D33989.diff
Fri, Dec 20, 2:10 PM
Unknown Object (File)
Thu, Dec 5, 10:49 AM
Unknown Object (File)
Wed, Dec 4, 10:17 PM
Unknown Object (File)
Nov 14 2024, 1:14 PM
Unknown Object (File)
Oct 15 2024, 8:05 AM
Unknown Object (File)
Oct 3 2024, 11:59 AM
Unknown Object (File)
Sep 25 2024, 8:18 AM
Unknown Object (File)
Sep 9 2024, 7:19 AM

Details

Summary

We provide the hostid (which is the state creatorid) to the kernel as a
big endian number (see pfctl/pfctl.c pfctl_set_hostid()), so convert it
back to system endianness when we get it from the kernel.

This avoids a confusing mismatch between the value the user configures
and the value displayed in the state.

MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44033
Build 40921: arc lint + arc unit