Page MenuHomeFreeBSD

libpfctl: fix creatorid endianness
ClosedPublic

Authored by kp on Jan 21 2022, 5:36 PM.
Tags
None
Referenced Files
F161592442: D33989.id101751.diff
Sun, Jul 5, 4:33 AM
F161574494: D33989.id101979.diff
Sun, Jul 5, 12:22 AM
Unknown Object (File)
Tue, Jun 30, 3:35 AM
Unknown Object (File)
Mon, Jun 29, 12:24 PM
Unknown Object (File)
Fri, Jun 19, 10:30 PM
Unknown Object (File)
Jun 1 2026, 6:17 PM
Unknown Object (File)
Jun 1 2026, 11:53 AM
Unknown Object (File)
Jun 1 2026, 5:13 AM

Details

Summary

We provide the hostid (which is the state creatorid) to the kernel as a
big endian number (see pfctl/pfctl.c pfctl_set_hostid()), so convert it
back to system endianness when we get it from the kernel.

This avoids a confusing mismatch between the value the user configures
and the value displayed in the state.

MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44033
Build 40921: arc lint + arc unit