ktls: Zero out TLS_GET_RECORD control messages
ClosedPublic
Actions

Authored by markj on Jan 19 2022, 8:18 PM.

Tags

None

Referenced Files

	F106553758: D33953.id101700.diff
	Wed, Jan 1, 6:00 PM

	Unknown Object (File)
	Fri, Dec 27, 2:26 AM

	Unknown Object (File)
	Fri, Dec 20, 7:51 PM

	Unknown Object (File)
	Fri, Dec 20, 1:59 PM

	Unknown Object (File)
	Wed, Dec 11, 8:31 PM

	Unknown Object (File)
	Sun, Dec 8, 6:14 PM

	Unknown Object (File)
	Wed, Dec 4, 11:19 AM

	Unknown Object (File)
	Nov 28 2024, 11:29 AM

View All 52 Files

Subscribers

imp

Details

Reviewers

jhb

Commits

rG6be8944d96d2: ktls: Zero out TLS_GET_RECORD control messages

Summary

Otherwise we end up copying uninitialized bytes into the socket buffer.

Reported by: KMSAN

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jan 19 2022, 8:18 PM

Herald added subscribers: ae, imp. · View Herald TranscriptJan 19 2022, 8:18 PM

markj requested review of this revision.Jan 19 2022, 8:18 PM

Harbormaster completed remote builds in B43991: Diff 101652.Jan 19 2022, 8:18 PM

Huh, we should be setting all of the fields? Is there a padding byte I guess?

In D33953#768089, @jhb wrote:

Huh, we should be setting all of the fields? Is there a padding byte I guess?

Yes, sorry the description isn't quite right. There is a single padding byte.

jhb accepted this revision.Jan 20 2022, 8:36 PM

This revision is now accepted and ready to land.Jan 20 2022, 8:36 PM

Closed by commit rG6be8944d96d2: ktls: Zero out TLS_GET_RECORD control messages (authored by markj). · Explain WhyJan 20 2022, 8:44 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG6be8944d96d2: ktls: Zero out TLS_GET_RECORD control messages.

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

tom/

t4_tls.c

1 line

kern/

uipc_ktls.c

1 line

Diff 101700

View Options

sys/dev/cxgbe/tom/t4_tls.c