graphics/zathura: Update to 0.4.8, Add SyncTeX support The port depended on libsynctex without ever using it, as it was never passed to the meson build, and even if it was, it would fail since it requires libsynctex >= 1.19.0 and the current version is 1.17.0. It now works as expected once D32264 lands. pkg-descr and pkg-message are also improved, and pkg-plist is updated with new paths for fish completion and the scalable app icon.
Details
Details
- Reviewers
quentin.stievenart_gmail.com koobs - Group Reviewers
Contributor Reviewers (ports) Ports Committers
- portlint:
- testport:
- other: I used it for days on FreeBSD 13.0-RELEASE
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 43675 Build 40563: arc lint + arc unit
Event Timeline
| graphics/zathura/Makefile | ||
|---|---|---|
| 30 | OPTION_DESC's should have descriptions that describe the feature/value from a user perspective. Sometimes this is just the name of the dependencies, but often it is not. In this case I believe SyncTeX is used for Zathura's 'Forward/Inverse Search' feature. One may consider:
In the latter case, the search group can have its own description like SEARCH_DESC"Forward/Inverse Search " and LATEX_DESC="Latex Support", or similasr | |
| 31 | Review summary says libsynctex >= 1.19.0 but this version spec is not added here. Perhaps depend on the packagename instead, allowing you to pass the version requirement. | |
| graphics/zathura/pkg-plist | ||
| 15 | Commit log message should describe the 'why' for all meaningful changes. What happened to this file? Not explained in the review summary. | |
| 21 | Commit log message should describe the 'why' for all meaningful changes. What happened to this file? Not explained in the review summary. | |
Comment Actions
- graphics/zathura: Add the new path for fish completion and scalable app icon to the pkg-plist
| graphics/zathura/Makefile | ||
|---|---|---|
| 31 | Is it OK now? I didn't know how to ask for a greater than or equal to a specific version. Please let me know if I should do it differently. | |
| graphics/zathura/pkg-plist | ||
| 15 | I forgot to add the new path when I deleted the old one, my apologies. | |
| 21 | Same as above, I forgot to add the new path when I deleted the old one, my apologies. | |
| graphics/zathura/Makefile | ||
|---|---|---|
| 30 | I improved the description but kept the title as is since Zathura uses the same term even on their website. But if you still think it's better to change it to something like SEARCH, let me know and I'll follow your call. | |
| graphics/zathura/Makefile | ||
|---|---|---|
| 30 | Is there synchronization support for other formats? Granted upstream describes the technology that drives the feature (synctex), but this still feels like: LATEX_DESC=LaTeX Synchronization Support with SyncTeX | |
| 31 | Depend on the package name, instead of the library like: RUN_DEPENDS=tex-synctex>=1.19.0:devel/tex-synctex If its also required at build time: BUILD_DEPENDS=tex-synctex>=1.19.0:devel/tex-synctex | |
| graphics/zathura/Makefile | ||
|---|---|---|
| 30 | I haven't seen forward/inverse search synchronisation anywhere else, but theoretically, there could be, and I just searched for inverse search technologies, and GNU LilyPond seems to have something similar. So yes, there should be similar implementations for other typesetting systems. Therefore, since Zathura is a general document viewer and they might implement other synchronisation technologies in future, we'd better use something more descriptive, right. But I go with TeX as the title since it's not only targeting LaTeX. Please let me know if you have another idea. TEX_DESC= Direct and reverse synchronisation support with SyncTeX | |
| graphics/zathura/Makefile | ||
|---|---|---|
| 31 | Done. Please let me know if there's anything else I could improve. | |