Page MenuHomeFreeBSD

Try to extract the RFC1048 data from PXE
ClosedPublic

Authored by kczekirda on Mar 1 2017, 5:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 3:52 AM
Unknown Object (File)
Feb 22 2024, 8:21 AM
Unknown Object (File)
Feb 17 2024, 4:21 PM
Unknown Object (File)
Feb 11 2024, 10:26 AM
Unknown Object (File)
Jan 31 2024, 5:15 AM
Unknown Object (File)
Jan 22 2024, 12:50 PM
Unknown Object (File)
Jan 21 2024, 8:42 AM
Unknown Object (File)
Jan 19 2024, 6:16 AM
Subscribers

Details

Summary

Try to extract the RFC1048 data from PXE. If we get enough info we can skip the bootp().
It removes unnecessary DHCP request from pxeloader.

I'm not sure if it should be a default, maybe somebody wants to give a different answer from DHCP, depends on stage of netboot on the same machine.

Initiated by: Matthew Dillon
https://docs.freebsd.org/cgi/getmsg.cgi?fetch=95542+0+archive/2003/freebsd-hackers/20030223.freebsd-hackers
Improved by: oshogbo
Sponsored by: Oktawave

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kczekirda retitled this revision from to Try to extract the RFC1048 data from PXE.
kczekirda updated this object.
kczekirda edited the test plan for this revision. (Show Details)
kczekirda added reviewers: oshogbo, bapt, tsoome, glebius, network.
gnn added a reviewer: gnn.
This revision is now accepted and ready to land.Mar 2 2017, 4:38 PM
smh requested changes to this revision.Mar 2 2017, 5:14 PM
smh added a reviewer: smh.
smh added a subscriber: smh.
smh added inline comments.
/usr/src/lib/libstand/bootp.h
151

Is this needed as it looks like its to ensure its only included once by the _BOOTP_H_ should achieve that

/usr/src/sys/boot/i386/libi386/pxe.c
282

The formatting here is a bit odd, remove the "." ?

299

Should this only be output under verbose boot or pxe_debug?

This revision now requires changes to proceed.Mar 2 2017, 5:14 PM
kczekirda edited edge metadata.
kczekirda marked 3 inline comments as done.
smh requested changes to this revision.Mar 2 2017, 10:02 PM
smh edited edge metadata.
smh added inline comments.
/usr/src/sys/boot/i386/libi386/pxe.c
300

You can squash the else and your if here

This revision now requires changes to proceed.Mar 2 2017, 10:02 PM
kczekirda updated this revision to Diff 25916.
kczekirda edited edge metadata.
kczekirda marked an inline comment as done.
kczekirda edited edge metadata.
smh requested changes to this revision.Mar 2 2017, 10:47 PM
smh edited edge metadata.
smh added inline comments.
/usr/src/sys/boot/i386/libi386/pxe.c
300

Looks like you have a brace miss match here now

This revision now requires changes to proceed.Mar 2 2017, 10:47 PM
kczekirda edited edge metadata.
kczekirda marked an inline comment as done.
/usr/src/sys/boot/i386/libi386/pxe.c
296

Didn't spot this before but does this need a more explicit test as this method returns and isn't not a book and it's not clear what's the -1 is meant to trigger and how it's dealt with here?

@smh
Is it work for you now?
I have one more patch from @kczekirda so is it ready for commit?

bapt edited edge metadata.
smh requested changes to this revision.Mar 3 2017, 4:32 PM
smh edited edge metadata.
smh added inline comments.
/usr/src/sys/boot/i386/libi386/pxe.c
296

space before the brace

This revision now requires changes to proceed.Mar 3 2017, 4:32 PM
kczekirda edited edge metadata.
kczekirda marked 2 inline comments as done.
smh edited edge metadata.
This revision is now accepted and ready to land.Mar 4 2017, 3:55 AM
This revision was automatically updated to reflect the committed changes.