Page MenuHomeFreeBSD
Differential D9847

Try to extract the RFC1048 data from PXE
ClosedPublic
Actions

Authored by kczekirda on Mar 1 2017, 5:47 PM.
Tags
None
Referenced Files
F105753499: D9847.id25915.diff
Fri, Dec 20, 4:33 AM
F105704736: D9847.id26089.diff
Thu, Dec 19, 11:10 AM
Unknown Object (File)
Fri, Dec 13, 9:15 PM
Unknown Object (File)
Fri, Dec 13, 12:38 AM
Unknown Object (File)
Wed, Dec 11, 11:04 AM
Unknown Object (File)
Sun, Dec 8, 3:28 PM
Unknown Object (File)
Tue, Dec 3, 8:18 PM
Unknown Object (File)
Sun, Dec 1, 3:16 AM
View All Files
Subscribers
smh

Details

Reviewers
freebsd-net-list
glebius
bapt
gnn
smh
oshogbo
tsoome
Group Reviewers
network
Commits
rS314948: Try to extract the RFC1048 data from PXE. If we get enough info we can skip
Summary

Try to extract the RFC1048 data from PXE. If we get enough info we can skip the bootp().
It removes unnecessary DHCP request from pxeloader.

I'm not sure if it should be a default, maybe somebody wants to give a different answer from DHCP, depends on stage of netboot on the same machine.

Initiated by: Matthew Dillon
https://docs.freebsd.org/cgi/getmsg.cgi?fetch=95542+0+archive/2003/freebsd-hackers/20030223.freebsd-hackers
Improved by: oshogbo
Sponsored by: Oktawave

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kczekirda updated this revision to Diff 25843.Mar 1 2017, 5:47 PM
kczekirda retitled this revision from to Try to extract the RFC1048 data from PXE.
kczekirda updated this object.
kczekirda edited the test plan for this revision. (Show Details)
kczekirda added reviewers: oshogbo, bapt, tsoome, glebius, network.
kczekirda added a reviewer: freebsd-net-list.Mar 1 2017, 7:22 PM
gnn accepted this revision.Mar 2 2017, 4:38 PM
gnn added a reviewer: gnn.
This revision is now accepted and ready to land.Mar 2 2017, 4:38 PM
smh requested changes to this revision.Mar 2 2017, 5:14 PM
smh added a reviewer: smh.
smh added a subscriber: smh.
smh added inline comments.
/usr/src/lib/libstand/bootp.h
151

Is this needed as it looks like its to ensure its only included once by the _BOOTP_H_ should achieve that

/usr/src/sys/boot/i386/libi386/pxe.c
282

The formatting here is a bit odd, remove the "." ?

299

Should this only be output under verbose boot or pxe_debug?

This revision now requires changes to proceed.Mar 2 2017, 5:14 PM
kczekirda updated this revision to Diff 25913.Mar 2 2017, 8:40 PM
kczekirda edited edge metadata.
kczekirda marked 3 inline comments as done.
kczekirda updated this revision to Diff 25914.Mar 2 2017, 8:50 PM
kczekirda edited edge metadata.
smh requested changes to this revision.Mar 2 2017, 10:02 PM
smh edited edge metadata.
smh added inline comments.
/usr/src/sys/boot/i386/libi386/pxe.c
300

You can squash the else and your if here

This revision now requires changes to proceed.Mar 2 2017, 10:02 PM
kczekirda updated this revision to Diff 25915.Mar 2 2017, 10:17 PM
kczekirda updated this revision to Diff 25916.
kczekirda edited edge metadata.
kczekirda marked an inline comment as done.
kczekirda edited edge metadata.
smh requested changes to this revision.Mar 2 2017, 10:47 PM
smh edited edge metadata.
smh added inline comments.
/usr/src/sys/boot/i386/libi386/pxe.c
300

Looks like you have a brace miss match here now

This revision now requires changes to proceed.Mar 2 2017, 10:47 PM
kczekirda updated this revision to Diff 25917.Mar 2 2017, 11:14 PM
kczekirda edited edge metadata.
kczekirda marked an inline comment as done.
smh added inline comments.Mar 3 2017, 6:52 AM
/usr/src/sys/boot/i386/libi386/pxe.c
296

Didn't spot this before but does this need a more explicit test as this method returns and isn't not a book and it's not clear what's the -1 is meant to trigger and how it's dealt with here?

smh added a comment.Mar 3 2017, 6:56 AM

book -> bool

kczekirda updated this revision to Diff 25931.Mar 3 2017, 10:26 AM
kczekirda edited edge metadata.
oshogbo edited edge metadata.EditedMar 3 2017, 10:34 AM

@smh
Is it work for you now?
I have one more patch from @kczekirda so is it ready for commit?

bapt accepted this revision.Mar 3 2017, 2:33 PM
bapt edited edge metadata.
smh requested changes to this revision.Mar 3 2017, 4:32 PM
smh edited edge metadata.
smh added inline comments.
/usr/src/sys/boot/i386/libi386/pxe.c
296

space before the brace

This revision now requires changes to proceed.Mar 3 2017, 4:32 PM
kczekirda updated this revision to Diff 25936.Mar 3 2017, 4:40 PM
kczekirda edited edge metadata.
kczekirda marked 2 inline comments as done.
smh accepted this revision.Mar 4 2017, 3:55 AM
smh edited edge metadata.
This revision is now accepted and ready to land.Mar 4 2017, 3:55 AM
Closed by commit rS314948: Try to extract the RFC1048 data from PXE. If we get enough info we can skip (authored by oshogbo). · Explain WhyMar 9 2017, 6:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr/
src/
lib/
libstand/
bootp.h
bootp.h.old
6 lines
bootp.c
bootp.c.old
11 lines
sys/
boot/
i386/
libi386/
pxe.c
pxe.c.old
29 lines

Diff 25931

View Options

/usr/src/lib/libstand/bootp.h

Loading...
View Options

/usr/src/lib/libstand/bootp.c

Loading...
View Options

/usr/src/sys/boot/i386/libi386/pxe.c

Loading...