Page MenuHomeFreeBSD

Fix broken visibility for symbols declared by DEFINE_AEABI_FUNCTION_ALIAS().
ClosedPublic

Authored by mmel on Feb 16 2017, 1:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 8 2024, 4:22 AM
Unknown Object (File)
Nov 20 2024, 7:15 AM
Unknown Object (File)
Oct 27 2024, 7:55 AM
Unknown Object (File)
Oct 22 2024, 4:06 PM
Unknown Object (File)
Oct 18 2024, 10:18 PM
Unknown Object (File)
Sep 30 2024, 12:25 AM
Unknown Object (File)
Sep 29 2024, 10:39 PM
Unknown Object (File)
Sep 22 2024, 5:54 PM
Subscribers

Details

Summary

EFINE_AEABI_FUNCTION_ALIAS() macro uses '.set' directive for
declaration of aliased symbol. Unfortunately, '.set' doesn't
inherit visibility of base symbol, and macro don’t explicitly
sets visibility for aliased one.

Note: DEFINE_AEABI_FUNCTION_ALIAS() is used only for ARM,
so this change doesn't affect other architectures.

MFC after: 2 months

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mmel retitled this revision from to Fix broken visibility for symbols declared by DEFINE_AEABI_FUNCTION_ALIAS()..
mmel updated this object.
mmel edited the test plan for this revision. (Show Details)
mmel added reviewers: kib, dim.
mmel set the repository for this revision to rS FreeBSD src repository - subversion.
mmel added a subscriber: ARM.
andrew added a subscriber: andrew.

This should be sent upstream

This is already done upstream slightly differently: https://reviews.llvm.org/rL285478

I will just import that revision instead. Since it is from upstream, I see no harm in MFC'ing it after 3 days.

This revision was automatically updated to reflect the committed changes.

Please, do not do it.
This must be MFCed together with r313866 or we broke all packages.
And I want little more time to be sure that r313866 is OK.

In D9633#199282, @meloun-miracle-cz wrote:

Please, do not do it.
This must be MFCed together with r313866 or we broke all packages.
And I want little more time to be sure that r313866 is OK.

Sure, just ping me when you need it MFC'd, or you can do it yourself if you like.