Page MenuHomeFreeBSD
Differential D9633

Fix broken visibility for symbols declared by DEFINE_AEABI_FUNCTION_ALIAS().
ClosedPublic
Actions

Authored by mmel on Feb 16 2017, 1:08 PM.
Tags
None
Referenced Files
F135867306: D9633.diff
Thu, Nov 13, 4:40 PM
Unknown Object (File)
Wed, Nov 12, 1:17 AM
Unknown Object (File)
Sat, Nov 8, 7:28 AM
Unknown Object (File)
Sat, Nov 8, 7:28 AM
Unknown Object (File)
Sat, Nov 8, 7:28 AM
Unknown Object (File)
Sat, Nov 8, 1:34 AM
Unknown Object (File)
Tue, Nov 4, 12:54 AM
Unknown Object (File)
Sun, Oct 26, 10:24 AM
View All 79 Files
Subscribers
andrew
imp
ARM

Details

Reviewers
kib
dim
emaste
Commits
rS313823: Pull in r285478 from upstream compiler-rt trunk (by Saleem Abdulrasool):
Summary

EFINE_AEABI_FUNCTION_ALIAS() macro uses '.set' directive for
declaration of aliased symbol. Unfortunately, '.set' doesn't
inherit visibility of base symbol, and macro don’t explicitly
sets visibility for aliased one.

Note: DEFINE_AEABI_FUNCTION_ALIAS() is used only for ARM,
so this change doesn't affect other architectures.

MFC after: 2 months

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mmel updated this revision to Diff 25268.Feb 16 2017, 1:08 PM
mmel retitled this revision from to Fix broken visibility for symbols declared by DEFINE_AEABI_FUNCTION_ALIAS()..
mmel updated this object.
mmel edited the test plan for this revision. (Show Details)
mmel added reviewers: kib, dim.
mmel set the repository for this revision to rS FreeBSD src repository - subversion.
mmel added a subscriber: ARM.
Herald added a subscriber: imp. · View Herald TranscriptFeb 16 2017, 1:08 PM
andrew added a reviewer: emaste.Feb 16 2017, 1:25 PM
andrew added a subscriber: andrew.

This should be sent upstream

dim edited edge metadata.Feb 16 2017, 8:49 PM

This is already done upstream slightly differently: https://reviews.llvm.org/rL285478

I will just import that revision instead. Since it is from upstream, I see no harm in MFC'ing it after 3 days.

Closed by commit rS313823: Pull in r285478 from upstream compiler-rt trunk (by Saleem Abdulrasool): (authored by dim). · Explain WhyFeb 16 2017, 9:04 PM
This revision was automatically updated to reflect the committed changes.
mmel added a comment.Feb 17 2017, 11:27 AM

Please, do not do it.
This must be MFCed together with r313866 or we broke all packages.
And I want little more time to be sure that r313866 is OK.

dim added a comment.Feb 17 2017, 7:12 PM
In D9633#199282, @meloun-miracle-cz wrote:

Please, do not do it.
This must be MFCed together with r313866 or we broke all packages.
And I want little more time to be sure that r313866 is OK.

Sure, just ping me when you need it MFC'd, or you can do it yourself if you like.

Revision Contents
Changeset List

PathSize
head/
contrib/
compiler-rt/
lib/
builtins/
1 line

Diff 25290

View Options

head/contrib/compiler-rt/lib/builtins/assembly.h

Loading...