Always NETIF_OPEN_CLOSE_ONCE
ClosedPublic
Actions

Authored by bapt on Oct 12 2016, 8:07 PM.

Details

Reviewers

gonzo
jhb
marius
tsoome

Commits

rS308719: MFC r307238:
rS307238: Stop closing the network device when netbooting for loaders using the common

Summary

When NETIF_OPEN_CLOSE_ONCE in rS201932 it was claimed that uboot was
was actually needing that behaviour. but all our u-boot loader are now
defining the flag.

Only the loader.efi is not defining it.

Remove the alternate code.

It vastly speeds up netbooting with loader.efi

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt updated this revision to Diff 21317.Oct 12 2016, 8:07 PM

bapt retitled this revision from to Always NETIF_OPEN_CLOSE_ONCE.

bapt updated this object.

bapt edited the test plan for this revision. (Show Details)

Herald added subscribers: andrew, imp. · View Herald TranscriptOct 12 2016, 8:07 PM

emaste added a subscriber: emaste.Oct 12 2016, 8:13 PM

emaste added inline comments.

sys/boot/powerpc/kboot/Makefile
74 ↗	(On Diff #21317)	`-mcpu` flag not needed?

bapt added reviewers: tsoome, jhb.Oct 12 2016, 8:23 PM

bapt added reviewers: gonzo, marius.

Readd -mcpu dropped by accident

bapt marked an inline comment as done.Oct 12 2016, 8:27 PM

bapt added inline comments.

sys/boot/powerpc/kboot/Makefile
74 ↗	(On Diff #21317)	oups :) fixed

sbruno added a subscriber: sbruno.Oct 12 2016, 8:39 PM

tsoome added inline comments.Oct 12 2016, 8:45 PM

sys/boot/powerpc/ps3/Makefile
74 ↗	(On Diff #21320)	another -mcpu lost?:D

Another mcpu lost

sys/boot/powerpc/ps3/Makefile
74 ↗	(On Diff #21320)	thanks fixed

Well, the claim that U-Boot requires !NETIF_OPEN_CLOSE_ONCE behavior actually is from r177108 so you probably should check with raj@ that this actually no longer is the case and the arm ubldr currently is doing the right thing.

Well the arm ubldr is built since 2015 with NETIF_OPEN_CLOSE_ONCE