Add support for SPI-mapped MSI interrupts in GICv3
ClosedPublic
Actions

Authored by mst_semihalf.com on Aug 26 2016, 4:21 PM.

Details

Reviewers

zbb
wma
imp
• ian

Commits

rS306069: Add support for SPI-mapped MSI interrupts in GICv3.

Summary

PIC_SETUP_INTR implementation in GICv3 did not allow for setting up interrupts without included FDT description. GICv2m-like MSI interrupts, which map MSI messages to SPI interrupt lines, may not have a description in FDT.
Add support for such interrupts by setting the trigger and polarity to the appropriate values for MSI (edge, high) and get the hardware IRQ number from the corresponding ISRC.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mst_semihalf.com updated this revision to Diff 19728.Aug 26 2016, 4:21 PM

mst_semihalf.com retitled this revision from to Add support for SPI-mapped MSI-X interrupts in GICv3.

mst_semihalf.com updated this object.

mst_semihalf.com edited the test plan for this revision. (Show Details)

mst_semihalf.com added reviewers: zbb, imp, • ian, wma.

mst_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.

mst_semihalf.com added a subscriber: arm64.

Herald added subscribers: emaste, andrew. · View Herald TranscriptAug 26 2016, 4:21 PM

mst_semihalf.com added a child revision: D7579: Support for MSI-X on Annapurna Alpine.Aug 26 2016, 4:28 PM

mst_semihalf.com mentioned this in D7579: Support for MSI-X on Annapurna Alpine.Aug 26 2016, 4:31 PM

mst_semihalf.com retitled this revision from Add support for SPI-mapped MSI-X interrupts in GICv3 to Add support for SPI-mapped MSI interrupts in GICv3.Aug 29 2016, 7:21 PM

mst_semihalf.com updated this object.

mst_semihalf.com mentioned this in D7698: Add support for SPI-mapped MSI interrupts outside of GICv2m.Aug 29 2016, 7:39 PM

wma accepted this revision.Sep 5 2016, 8:46 AM

wma edited edge metadata.

This revision is now accepted and ready to land.Sep 5 2016, 8:46 AM

Move the code to a separate function gic_map_msi() similarly to D7698.

This revision now requires review to proceed.Sep 8 2016, 7:21 PM

Closed by commit rS306069: Add support for SPI-mapped MSI interrupts in GICv3. (authored by wma). · Explain WhySep 21 2016, 5:23 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

gic_v3.c

27 lines

Diff 20565

View Options

head/sys/arm64/arm64/gic_v3.c

Add support for SPI-mapped MSI interrupts in GICv3ClosedPublicActions