Page MenuHomeFreeBSD

Register GICv3 xref
ClosedPublic

Authored by mst_semihalf.com on Aug 18 2016, 6:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 12:49 PM
Unknown Object (File)
Fri, Dec 6, 4:40 PM
Unknown Object (File)
Nov 24 2024, 2:43 AM
Unknown Object (File)
Nov 12 2024, 6:33 PM
Unknown Object (File)
Oct 29 2024, 2:53 AM
Unknown Object (File)
Oct 4 2024, 2:57 AM
Unknown Object (File)
Oct 2 2024, 10:49 AM
Unknown Object (File)
Sep 30 2024, 9:49 AM

Details

Summary

This allows other drivers to retrieve interrupt parent node.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mst_semihalf.com retitled this revision from to Register GICv3 xref.
mst_semihalf.com updated this object.
mst_semihalf.com edited the test plan for this revision. (Show Details)
mst_semihalf.com added reviewers: zbb, imp.
mst_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
mst_semihalf.com added a subscriber: arm64.

Why do you need to retrieve this? It's normally done through INTRNG.

sys/arm64/arm64/gic_v3.c
244 ↗(On Diff #19464)

This line no longer exists, you are on an old copy of the file.

Updated base file version - no change in added code.

sys/arm64/arm64/gic_v3.c
244 ↗(On Diff #19464)

I updated the diff, now it bases on the current version of the file.

Why do you need to retrieve this? It's normally done through INTRNG.

D7579 uses this to retrieve iparent and PIC dev to be able to call PIC_* methods.

zbb edited edge metadata.
zbb added inline comments.
sys/arm64/arm64/gic_v3.c
219 ↗(On Diff #19726)

Shouldn't this be phandle_t?

This revision is now accepted and ready to land.Sep 6 2016, 3:32 PM
sys/arm64/arm64/gic_v3.c
219 ↗(On Diff #19726)

phandle_t doesn't exist in ACPI world.

My only concern is if we can move this part of code to another file, like gicv3_fdt, where we have xref stuff already. In the present shape it fails to compile when FDT support is disabled.

mst_semihalf.com edited edge metadata.

Move xref registration to gic_v3_fdt.c

This revision now requires review to proceed.Sep 8 2016, 3:38 PM
In D7568#162015, @wma wrote:

My only concern is if we can move this part of code to another file, like gicv3_fdt, where we have xref stuff already. In the present shape it fails to compile when FDT support is disabled.

Fixed.

This revision was automatically updated to reflect the committed changes.