Page MenuHomeFreeBSD
Differential D7698

Add support for SPI-mapped MSI interrupts outside of GICv2m
ClosedPublic
Actions

Authored by mst_semihalf.com on Aug 29 2016, 7:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 6:43 PM
Unknown Object (File)
Sat, Oct 26, 3:25 AM
Unknown Object (File)
Sat, Oct 19, 10:22 AM
Unknown Object (File)
Sep 17 2024, 10:40 PM
Unknown Object (File)
Sep 16 2024, 6:45 AM
Unknown Object (File)
Aug 17 2024, 7:21 AM
Unknown Object (File)
Aug 11 2024, 3:55 PM
Unknown Object (File)
Aug 4 2024, 6:28 AM
View All 85 Files
Subscribers
andrew
skra
ARM

Details

Reviewers
zbb
wma
imp
• ian
Commits
rS306070: Add support for SPI-mapped MSI interrupts outside of GICv2m.
Summary

SPI-mapped MSI interrupts coming from a controller other than GICv2m need to have their trigger and polarity properly configured.
This patch fixes MSI/MSI-X on Annapurna Alpine platform with GICv2. D7662 is a similar patch for GICv3.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mst_semihalf.com updated this revision to Diff 19799.Aug 29 2016, 7:39 PM
mst_semihalf.com retitled this revision from to Add support for SPI-mapped MSI interrupts outside of GICv2m.
mst_semihalf.com updated this object.
mst_semihalf.com edited the test plan for this revision. (Show Details)
mst_semihalf.com added reviewers: zbb, wma, imp, • ian.
mst_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
mst_semihalf.com added a subscriber: ARM.
Herald added a subscriber: andrew. · View Herald TranscriptAug 29 2016, 7:39 PM
skra added a subscriber: skra.Aug 31 2016, 9:21 AM
skra added inline comments.
sys/arm/arm/gic.c
917 ↗(On Diff #19799)

There is a switch according to struct intr_map_data data type in gic_map_intr() already. So, I would prefer to put INTR_MAP_DATA_MSI case in it. And creation of gic_map_msi() would be nice to be similar to gic_map_fdt() in FDT case.

mst_semihalf.com updated this revision to Diff 19884.Aug 31 2016, 5:58 PM

Move the code to a new function gic_map_msi() and call it in gic_map_intr() switch case for MSI. No functional changes.

mst_semihalf.com added inline comments.Aug 31 2016, 6:02 PM
sys/arm/arm/gic.c
917 ↗(On Diff #19799)

Thanks for the comment, I added a new revision which changes it - please check if it's what you meant.

wma accepted this revision.Sep 5 2016, 6:51 AM
wma edited edge metadata.

So, are we done with this change? I'll commit this patch today if no further issues are reported. Thanks.

This revision is now accepted and ready to land.Sep 5 2016, 6:51 AM
mst_semihalf.com mentioned this in D7662: Add support for SPI-mapped MSI interrupts in GICv3.Sep 8 2016, 7:21 PM
Closed by commit rS306070: Add support for SPI-mapped MSI interrupts outside of GICv2m. (authored by wma). · Explain WhySep 21 2016, 5:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
arm/
28 lines

Diff 20567

View Options

head/sys/arm/arm/gic.c

Loading...