Reported by: fluffy
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
So is there some reason this can't be just
/* This file is in the public domain */ #pragma once #include <sys/_floatingpoint.h>
where sys/_floatingpoint.h is
/* This file is in the public domain */ #pragma once #include <sys/cdefs.h> #include <machine/ieeefp.h>
| sys/arm/include/floatingpoint.h | ||
|---|---|---|
| 33 | same comment as the arm64 fp. | |
| sys/arm64/include/floatingpoint.h | ||
| 19 | So this advertising clause suggests that we can just dump this entire license. This file is now 2 lines of includes that are dictated by externalities. This means we can either just do what I did for a bunch of files and say it's public domain, or just put our own license on this file. | |
pragma once is not the standard C. Besides my high dislike of avoidable non-standard features, note that the header is public and absolutely must work with non-gcc-like compilers.
Having header file including sys/_floatingpoint.h IMO does not buy us anything. I would understand the argument of moving inclusion of sys/cdefs.h into ieeefp.h but we still need the machine/floatingpoint.h
WRT license, it is strange to have two otherwise identical files under different licenses, but I will get any advise there.