Page MenuHomeFreeBSD
Differential D60238

devel/py-pyinstaller: fix build on ARM64
Needs ReviewPublic
Actions

Authored by bsd.hsw_gmail.com on Fri, Oct 2, 10:06 AM.
Tags
None
Referenced Files
F174633490: D60238.id188381.diff
Sun, Oct 4, 7:52 PM
Unknown Object (File)
Sat, Oct 3, 9:58 PM
Unknown Object (File)
Sat, Oct 3, 5:52 AM
Unknown Object (File)
Sat, Oct 3, 4:33 AM
Unknown Object (File)
Sat, Oct 3, 12:11 AM
Unknown Object (File)
Fri, Oct 2, 7:24 PM
Subscribers
arrowd

Details

Reviewers
None
Group Reviewers
Contributor Reviewers (ports)
Summary

The problem is that /usr/include/floatingpoint.h on AMD64 includes sys/cdefs.h
but the ARM64 version does not.

Patch the pyinstaller main.c to include sys/cdefs.h before including floatingpoint.h

Signed-off-by: Christopher Hall <bsd.hsw@gmail.com>

Test Plan

poudriere to build on AMD64 and ARM64/QEMU

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77612
Build 74495: arc lint + arc unit

Event Timeline

bsd.hsw_gmail.com requested review of this revision.Fri, Oct 2, 10:06 AM
bsd.hsw_gmail.com created this revision.
Harbormaster completed remote builds in B77612: Diff 188381.Fri, Oct 2, 10:06 AM
arrowd added a subscriber: arrowd.Fri, Oct 2, 5:43 PM

What is the error message without this patch?

arrowd added a comment.Fri, Oct 2, 7:52 PM

A fix for the root issue is here: https://reviews.freebsd.org/D60255

bsd.hsw_gmail.com added a comment.EditedSat, Oct 3, 4:58 AM
The error is about __BEGIN_DECLS and __END_DECLS being undefined.

Harmonising the floatingpoint.h to always have sys/cdefs.h is probably the best fix,

Revision Contents
Changeset List

PathSize
devel/
py-pyinstaller/
files/
10 lines

Diff 188381

View Options

devel/py-pyinstaller/files/patch-bootloader_src_main.c

Loading...