Page MenuHomeFreeBSD

tests/sys/vfs: add ABI-root absolute symlink tests
ClosedPublic

Authored by dteske on Thu, Sep 24, 3:49 PM.
Tags
None
Referenced Files
F173534012: D59990.diff
Sat, Sep 26, 4:19 PM
Unknown Object (File)
Fri, Sep 25, 1:39 PM
Unknown Object (File)
Fri, Sep 25, 11:15 AM
Unknown Object (File)
Fri, Sep 25, 8:17 AM
Unknown Object (File)
Fri, Sep 25, 6:11 AM
Unknown Object (File)
Fri, Sep 25, 2:30 AM
Unknown Object (File)
Fri, Sep 25, 1:36 AM
Unknown Object (File)
Thu, Sep 24, 8:06 PM

Details

Summary

Pin the overlay namei(9) uses for Linux ABI processes: a target under
the ABI root wins (PR 289739), a native-only target should retry from
the native root (PR 297426), an ENOENT past a resolved ABI target is
not retried, and the plain no-symlink native fallback is unchanged.
Skip without a Linux userland so CI stays green. The two native-only
cases use atf_expect_fail until the retry lands.

PR: 297426

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dteske created this revision.

I did not read the details of the tests, but I do not see a reason not to commit them now.

Still I have one suggestion (or request if you prefer that name). Could you please annotate each test with expanded file structures that describe the disposition of the directories and symlinks created by tests. I mean, I might want to debug the stuff instead of just running tests, and for that I want to be able to recreate the test configuration of files without running the kyua machinery. Then not having to decipher the innards of the test shell scripts would save energy.

In D59990#1376636, @kib wrote:

I did not read the details of the tests, but I do not see a reason not to commit them now.

Still I have one suggestion (or request if you prefer that name). Could you please annotate each test with expanded file structures that describe the disposition of the directories and symlinks created by tests. I mean, I might want to debug the stuff instead of just running tests, and for that I want to be able to recreate the test configuration of files without running the kyua machinery. Then not having to decipher the innards of the test shell scripts would save energy.

Will do. Tree comment on each case: native vs ABI layout, the symlink, and the expected result, so the fixture can be rebuilt by hand without kyua.

Add reproduction step comments to tests

This revision is now accepted and ready to land.Sat, Sep 26, 4:33 PM