Page MenuHomeFreeBSD

armv8crypto: Canonicalize document description
AcceptedPublic

Authored by ziaee on Wed, Sep 16, 4:32 PM.
Tags
None
Referenced Files
F172420442: D59730.id186901.diff
Fri, Sep 18, 8:38 AM
F172392529: D59730.id.diff
Fri, Sep 18, 4:20 AM
Unknown Object (File)
Thu, Sep 17, 10:27 PM
Unknown Object (File)
Thu, Sep 17, 9:27 PM
Unknown Object (File)
Thu, Sep 17, 8:54 PM
Unknown Object (File)
Thu, Sep 17, 7:21 AM
Unknown Object (File)
Thu, Sep 17, 2:28 AM
Unknown Object (File)
Thu, Sep 17, 2:25 AM
Subscribers

Details

Reviewers
jhb
adrian
andrew
fuz
Group Reviewers
manpages
Summary

I think arm is calling the (sub?)devices implementing these extensions
"Arm Security Algorithm Accelerators", which sounds good. We should do
the same. Also the previous description was incomplete.

We may want to still keep CPU as a keyword, but I don't really think so.

https://support.arm.com/downloads/-/arm-security-algorithm-accelerators

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76990
Build 73873: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Wed, Sep 16, 4:32 PM

Arm Security Algorithm Accelerators

These are separate IP blocks SoC vendors can use in conjunction with the cryptographic instructions. Unrelated.

Note that there is not only the AES extension, but also the PMULL, SHA1, and SHA2 extensions, which may or may not end up being used by this driver (didn't check). For hashing within the kernel, we use the SHA1 and SHA2 extensions regardless of whether arvm8crypto(4) is loaded or not.

share/man/man4/man4.aarch64/armv8crypto.4
32

This matches the Arm Architecture Reference Manual for A-profile Architecture, § A2.12 “The Armv8 Cryptographic Extension.”

what about without the "v8" since it's in the name?
i'm looking at this [0] and it seems to call it "Arm Cryptographic Extension" more often than not.

https://support.arm.com/documentation/ddi0487/mc/?lang=en

what about without the "v8" since it's in the name?
i'm looking at this [0] and it seems to call it "Arm Cryptographic Extension" more often than not.

https://support.arm.com/documentation/ddi0487/mc/?lang=en

We still support Armv7, which doesn't have this. Armv8 (both in 32 and 64 bit mode) has this extension, so it sounds like a good idea to stick with armv8.

Let's wait for @andrew for final feedback as he works at ARM and probably has the best knowledge about this.

This revision is now accepted and ready to land.Wed, Sep 16, 6:06 PM