Page MenuHomeFreeBSD

tests/sys/kern: skip unix_connectat fdescfs cases when fdescfs is missing
Needs ReviewPublic

Authored by nickbanks_netflix.com on Thu, Aug 27, 6:43 PM.
Tags
None
Referenced Files
F168387502: D59227.diff
Thu, Aug 27, 10:45 PM
F168385711: D59227.diff
Thu, Aug 27, 10:26 PM
F168374012: D59227.id185232.diff
Thu, Aug 27, 8:30 PM
F168373531: D59227.diff
Thu, Aug 27, 8:27 PM
Subscribers

Details

Reviewers
olivier
Summary

unix_connectat's fdescfs cases call mount_fdescfs(), which skipped on
ENODEV. nmount(2) never returns ENODEV: vfs_donmount() remaps the
ENODEV from a failed fdescfs module load to EINVAL with errmsg
"Invalid fstype", so the skip never fired and the cases failed on
kernels without fdescfs.

Use ATF_REQUIRE_KERNEL_MODULE("fdescfs") instead, and drop the dead
ENODEV branch. modfind(2) sees loaded and static modules, not
unloaded .ko files, so a host with fdescfs.ko on disk but not loaded
will now skip rather than having nmount(2) implicitly kldload it.
Upstream CI keeps fdescfs mounted via tests/ci/tools/ci.conf, so it
still runs them.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76224
Build 73107: arc lint + arc unit