Avoid underflow during calculation of space avail for nsegs
ClosedPublic
Actions

Authored by sbruno on Apr 11 2016, 6:15 PM.

Details

Reviewers

kmacy
scottl
hiren
gnn

Group Reviewers

Intel Networking

Commits

rS298224: Correct possible underflow conditions when checking for available space

Summary

Change logic to check tx_avail < nsegs + reserved_space

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sbruno updated this revision to Diff 15088.Apr 11 2016, 6:15 PM

sbruno retitled this revision from to Avoid underflow during calculation of space avail for nsegs.

sbruno updated this object.

sbruno edited the test plan for this revision. (Show Details)

sbruno added reviewers: hiren, gnn.

Herald added a reviewer: Intel Networking. · View Herald TranscriptApr 11 2016, 6:15 PM

Herald added a subscriber: imp. · View Herald Transcript

gnn accepted this revision.Apr 11 2016, 9:32 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Apr 11 2016, 9:32 PM

Just tagging you guys to see if this makes sense. I saw the em(4) driver underflow this calculation with dtrace and suspected that there is a small chance the other Intel drivers may do the same in extreme conditions considering that the code is basically the same.

Looks good to me.