Page MenuHomeFreeBSD
Differential D59142

tcp: minor cleanup
ClosedPublic
Actions

Authored by tuexen on Mon, Aug 24, 7:47 AM.
Tags
None
Referenced Files
F169132950: D59142.id184868.diff
Mon, Aug 31, 1:09 PM
Unknown Object (File)
Sun, Aug 30, 4:19 PM
Unknown Object (File)
Sun, Aug 30, 11:53 AM
Unknown Object (File)
Sat, Aug 29, 12:46 PM
Unknown Object (File)
Fri, Aug 28, 8:36 PM
Unknown Object (File)
Fri, Aug 28, 2:14 PM
Unknown Object (File)
Fri, Aug 28, 8:50 AM
Unknown Object (File)
Fri, Aug 28, 1:49 AM
View All 22 Files
Subscribers
glebius
imp
melifaro
pouria

Details

Reviewers
rscheff
timo.voelker_fh-muenster.de
peter.lei_ieee.org
lstewart
nickbanks_netflix.com
pouria
Group Reviewers
transport
Commits
rG191dad334c64: tcp: minor cleanup
Summary

Several cleanups in tcp_input_with_port():

  • Don't assign m twice.
  • Don't reassign pointers without having done pullup().
  • While there, change the type of isipv6 to bool, since it is used that way.

No functional change intended.

Reported by: Hannes Elfert

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Mon, Aug 24, 7:47 AM
Herald added a reviewer: transport. · View Herald TranscriptMon, Aug 24, 7:47 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Mon, Aug 24, 7:47 AM
pouria accepted this revision.Mon, Aug 24, 10:03 AM
pouria added a subscriber: pouria.

LGTM

This revision is now accepted and ready to land.Mon, Aug 24, 10:03 AM
timo.voelker_fh-muenster.de accepted this revision.Mon, Aug 24, 10:49 AM

Looks like code improvements to me. I also don't see a functional change.

nickbanks_netflix.com accepted this revision.Mon, Aug 24, 11:40 AM
Closed by commit rG191dad334c64: tcp: minor cleanup (authored by tuexen). · Explain WhyMon, Aug 24, 7:07 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rG191dad334c64: tcp: minor cleanup.

Revision Contents
Changeset List

PathSize
sys/
netinet/
13 lines

Diff 184932

View Options

sys/netinet/tcp_input.c

Loading...