Page MenuHomeFreeBSD

if_wg: Prefix crypto_init() & crypto_deinit() with wg_ for a cleaner namespace.
AcceptedPublic

Authored by bms on Aug 1 2026, 6:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 27, 7:00 PM
Unknown Object (File)
Thu, Aug 27, 3:30 PM
Unknown Object (File)
Thu, Aug 27, 2:14 PM
Unknown Object (File)
Mon, Aug 24, 6:24 PM
Unknown Object (File)
Sun, Aug 23, 9:03 AM
Unknown Object (File)
Wed, Aug 19, 1:03 AM
Unknown Object (File)
Mon, Aug 17, 10:16 PM
Unknown Object (File)
Sun, Aug 16, 8:34 PM
Subscribers

Details

Summary

Both these functions have non-static linkage for good reasons, however, their
naming may confuse folk when working with crypto(9) code at global scope.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75333
Build 72216: arc lint + arc unit

Event Timeline

bms requested review of this revision.Aug 1 2026, 6:36 PM
bms created this revision.
pouria added a subscriber: pouria.

I'm not sure whether they can be static or not, but the naming is definitely not right.

This revision is now accepted and ready to land.Aug 1 2026, 6:55 PM

I'm not sure whether they can be static or not, but the naming is definitely not right.

Thanks. I'd like to know what @jhb thinks as he did most of the heavy lifting towards the end of wg(4) landing, and so that there is no unneeded divergence from Jason Donenfeld's upstream.

Makes sense to wait for jhb@ for a few days.

Makes sense to wait for jhb@ for a few days.

Technically sys/dev/wg is not declared in MAINTAINERS, nor is sys/crypto, but I'd be leveraging @jhb 's wg(4) work as an example for driving OCF in software mode. Sam Leffler firmed up the case for doing it in 2003, and this applies even now, despite kTLS being dependent upon kernel-space OpenSSL components; testing with the appropriate ConnectX models is out of my dev budget right now, for example.

There was expressed interest in TCP-AO by @jmg on behalf of his employer some months back. It appears they have TCP-AO in their EVO trains by way of being based on Linux, but not for the primary FreeBSD-based trains which ~30% of core Internet relies on.

I'd aim to land some infrastructure bits first, my continuing to pick up on the abandoned TCP-AO work from the early 2010s is a possibility, but I would need financial support for it to be viable for me to do this.

There's also the small matter of people happily writing blog posts about TCP-AO, yet not pointing to any production deployments, even at IXPs, and even right now.