Paths

Table of Contentst

Differential D58583

kqueue: fix the always-empty NT_PROCSTAT_KQUEUES core note
ClosedPublic
Actions

Authored by guest-seuros on Sat, Aug 1, 7:44 AM.

Tags

None

Referenced Files

	F165030333: D58583.id183335.diff
	Wed, Aug 5, 9:45 AM

	F164999092: D58583.diff
	Wed, Aug 5, 6:56 AM

	Unknown Object (File)
	Tue, Aug 4, 7:14 AM

	Unknown Object (File)
	Tue, Aug 4, 5:29 AM

	Unknown Object (File)
	Mon, Aug 3, 2:31 PM

	Unknown Object (File)
	Mon, Aug 3, 7:56 AM

	Unknown Object (File)
	Mon, Aug 3, 6:53 AM

	Unknown Object (File)
	Mon, Aug 3, 1:23 AM

Subscribers

Details

Reviewers

kib
markj
imp
adrian
jhb

Commits

rG5078280bb42c: kqueue: fix the always-empty NT_PROCSTAT_KQUEUES core note

Summary

sbuf reserves a byte of its buffer for the terminator, so the sbuf
created with maxlen held one byte less than the sizing pass had
computed. The last record overflowed it, sbuf_bcat() failed, and the
error == 0 guard skipped the copy into the caller's sbuf, so the note
has been emitted at full size but zero filled since 5e7c43ff02dc.

Fixes: 5e7c43ff02dc

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

guest-seuros created this revision.Sat, Aug 1, 7:44 AM

Herald added a subscriber: olce. · View Herald TranscriptSat, Aug 1, 7:44 AM

guest-seuros requested review of this revision.Sat, Aug 1, 7:44 AM

Harbormaster completed remote builds in B75327: Diff 183196.Sat, Aug 1, 7:44 AM

guest-seuros added a child revision: D58584: kqueue: stream the knote report instead of buffering all of it.Sat, Aug 1, 8:02 AM

guest-seuros added a reviewer: jhb.Sat, Aug 1, 3:43 PM

adrian accepted this revision.Sun, Aug 2, 3:50 PM

This revision is now accepted and ready to land.Sun, Aug 2, 3:50 PM

Please be sure to include a Fixes: tag in the commit log message.

guest-seuros edited the summary of this revision. (Show Details)Mon, Aug 3, 3:07 PM

Closed by commit rG5078280bb42c: kqueue: fix the always-empty NT_PROCSTAT_KQUEUES core note (authored by guest-seuros, committed by adrian). · Explain WhyMon, Aug 3, 6:16 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG5078280bb42c: kqueue: fix the always-empty NT_PROCSTAT_KQUEUES core note.

Revision Contents
Changeset List

Path

Size

sys/

kern/

2 lines

Diff 183335

sys/kern/kern_event.c

Loading...