Page MenuHomeFreeBSD
Differential D58577

ptrace: Propagate errors from set_fpregs()
ClosedPublic
Actions

Authored by markj on Jul 31 2026, 3:30 PM.
Tags
None
Referenced Files
F171748590: D58577.diff
Sun, Sep 13, 6:15 AM
Unknown Object (File)
Thu, Sep 10, 10:53 PM
Unknown Object (File)
Sun, Sep 6, 3:25 PM
Unknown Object (File)
Thu, Sep 3, 7:08 AM
Unknown Object (File)
Thu, Sep 3, 7:04 AM
Unknown Object (File)
Wed, Sep 2, 6:48 PM
Unknown Object (File)
Tue, Sep 1, 9:43 AM
Unknown Object (File)
Tue, Sep 1, 9:36 AM
View All 53 Files
Subscribers
imp
olce

Details

Reviewers
kib
Commits
rG1932bd20ed53: ptrace: Propagate errors from set_fpregs()
Summary

Otherwise ptrace(PT_SETREGSET) will not return errors to userspace.

Fixes: cef05c5a62ba ("amd64: do not allow to set reserved bits in MXCSR for ptrace(PT_SETFPREGS)")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jul 31 2026, 3:30 PM
Herald added subscribers: olce, imp. · View Herald TranscriptJul 31 2026, 3:30 PM
markj requested review of this revision.Jul 31 2026, 3:30 PM
Harbormaster completed remote builds in B75320: Diff 183164.Jul 31 2026, 3:30 PM
kib accepted this revision.Jul 31 2026, 3:40 PM
kib added inline comments.
sys/kern/imgact_elf.c
2395

Or just return (set_fpregsXX(...) == 0);

2398–2399

Same there, then return (true); is not needed.

This revision is now accepted and ready to land.Jul 31 2026, 3:40 PM
markj updated this revision to Diff 183166.Jul 31 2026, 3:44 PM

Simplify

This revision now requires review to proceed.Jul 31 2026, 3:44 PM
Harbormaster completed remote builds in B75321: Diff 183166.Jul 31 2026, 3:44 PM
kib accepted this revision.Jul 31 2026, 3:47 PM
This revision is now accepted and ready to land.Jul 31 2026, 3:47 PM
Closed by commit rG1932bd20ed53: ptrace: Propagate errors from set_fpregs() (authored by markj). · Explain WhyJul 31 2026, 7:48 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG1932bd20ed53: ptrace: Propagate errors from set_fpregs().

Revision Contents
Changeset List

PathSize
sys/
kern/
8 lines

Diff 183181

View Options

sys/kern/imgact_elf.c

Loading...