rip6: Fix handling of checksums in rip6_input()
ClosedPublic
Actions

Authored by markj on Thu, Jul 30, 6:52 PM.

Details

Reviewers

glebius
pouria

Group Reviewers

network

Commits

rG196874ce2e97: rawip: Fix handling of checksums in rip6_input()

Summary

A v6 raw socket may ask the kernel to validate the checksum of an
inbound packet. If so, and the validation fails, we discard the packet,
but this isn't really right: other raw sockets may wish to receive a
copy of the packet anyway.

Rework checksum handling to address this problem, and use a flag to
avoid computing the checksum more than once for a given packet.

Fixes: de2d47842e880281 ("SMR protection for inpcbs")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Thu, Jul 30, 6:52 PM

Herald added subscribers: pouria, melifaro, ae, imp. · View Herald TranscriptThu, Jul 30, 6:52 PM

markj requested review of this revision.Thu, Jul 30, 6:52 PM

Harbormaster completed remote builds in B75298: Diff 183127.Thu, Jul 30, 6:52 PM

LGTM

This revision is now accepted and ready to land.Mon, Aug 3, 8:37 AM

I'd suggest to change commit header to "raw ip6: Fix handling of checksums in rip6_input()", or "rawip: ...". The "rip" abbreviation can be easily confused with routing protocol. Unfortunately, I already made a precedent in the past with "rip: " header. And you already pushed changes with a better "rawip: " header to this file. The IPv4 sibling has quite a long precedence of using "raw ip: ".

Closed by commit rG196874ce2e97: rawip: Fix handling of checksums in rip6_input() (authored by markj). · Explain WhyWed, Aug 5, 1:14 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG196874ce2e97: rawip: Fix handling of checksums in rip6_input().