stand: Remove a pointless goto

[jhb]

Summary

Commit 505222d35fea removed a batch of code that this goto used to skip
around.

Fixes: 505222d35fea ("Implement the long-awaited module->file cache database. A userland tool (kldxref(8)) keeps a cache of what modules and versions are inside what .ko files. I have tested this on both Alpha and i386.")

[olce]

While here, you could apply the same treatment to the preceding if, except the call to parse_modmetadata() needs to be preserved. The fact that the return process is the same irrespective of whether that latter call returns 0 or not looks suspect. After a very quick glance, this function does not seem to have proper error reporting anyway.

[jhb]

In D58539#1343744, @olce wrote:

While here, you could apply the same treatment to the preceding if, except the call to parse_modmetadata() needs to be preserved. The fact that the return process is the same irrespective of whether that latter call returns 0 or not looks suspect. After a very quick glance, this function does not seem to have proper error reporting anyway.

See followup in the stack