Page MenuHomeFreeBSD

procdesc: Remove dead code
ClosedPublic

Authored by markj on Jul 22 2026, 3:47 PM.
Tags
None
Referenced Files
F170954642: D58396.diff
Mon, Sep 7, 8:25 PM
Unknown Object (File)
Sun, Sep 6, 5:05 AM
Unknown Object (File)
Sun, Sep 6, 5:05 AM
Unknown Object (File)
Sat, Sep 5, 7:16 PM
Unknown Object (File)
Fri, Sep 4, 11:14 AM
Unknown Object (File)
Thu, Sep 3, 11:08 PM
Unknown Object (File)
Thu, Sep 3, 10:12 AM
Unknown Object (File)
Wed, Sep 2, 10:55 AM
Subscribers

Details

Summary

As far as I can see, it is impossible for procdesc_exit() to observe
pd->pd_fpcount == 0: if procdesc_close() decrements that counter to
zero, then it will clean up the procdesc structure too, and this is
atomic with respect to the proctree lock.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Jul 22 2026, 3:47 PM
kib added inline comments.
sys/kern/sys_procdesc.c
281

Can we please lave the bool return type for now? It conflicts with the p_zombieref patch.

This revision is now accepted and ready to land.Jul 23 2026, 12:49 AM
markj added inline comments.
sys/kern/sys_procdesc.c
281

I will just not commit this until your patch lands.

sys/kern/sys_procdesc.c
281

In fact, no need, this was over-reaction. Please go ahead.

This revision was automatically updated to reflect the committed changes.
markj marked an inline comment as done.