linker: Recognize SHT_INIT_ARRAY sections as constructor sections
ClosedPublic
Actions

Authored by markj on Tue, Jul 14, 11:09 PM.

Details

Reviewers

Commits

rG83181995593a: linker: Recognize SHT_INIT_ARRAY sections as constructor sections

Summary

We do this already for ET_REL files, but it was missed here. Note that
this function operates only on dynamically loaded files, not on
preloaded files.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Tue, Jul 14, 11:09 PM

Herald added subscribers: olce, imp. · View Herald TranscriptTue, Jul 14, 11:09 PM

markj requested review of this revision.Tue, Jul 14, 11:09 PM

Harbormaster completed remote builds in B74817: Diff 182012.Tue, Jul 14, 11:09 PM

markj added a parent revision: D58244: stand: Recognize SHT_INIT_ARRAY sections as constructor sections.Tue, Jul 14, 11:09 PM

kib accepted this revision.Wed, Jul 15, 1:35 PM

kib added inline comments.

sys/kern/link_elf.c
1311	In theory there could be both init and initarray

This revision is now accepted and ready to land.Wed, Jul 15, 1:35 PM

markj added inline comments.Wed, Jul 15, 2:41 PM

sys/kern/link_elf.c
1311	My motivation is really just to handle a specific case where .init_array is added by KASAN. We are not executing constructors for the kernel since for some reason we rely on the loader to pass them down in module metadata.