bhyve: unsigned <= 0
ClosedPublic
Actions

Authored by tsoome on Mon, Jul 13, 2:06 PM.

Tags

None

Referenced Files

	F163330466: D58213.id181907.diff
	Wed, Jul 22, 4:28 AM

	F163329767: D58213.id181907.diff
	Wed, Jul 22, 4:20 AM

	F163329764: D58213.id181907.diff
	Wed, Jul 22, 4:20 AM

	F163298726: D58213.id181925.diff
	Tue, Jul 21, 8:17 PM

	F163297947: D58213.id181925.diff
	Tue, Jul 21, 8:09 PM

	Unknown Object (File)
	Mon, Jul 20, 11:30 PM

	Unknown Object (File)
	Mon, Jul 20, 10:49 PM

	Unknown Object (File)
	Mon, Jul 20, 11:31 AM

Subscribers

Details

Reviewers

bnovkov

Group Reviewers

bhyve

Commits

rG575529a92d7b: bhyve: unsigned <= 0

Summary

illumos smatch build is complaining:

pci_nvme_parse_config() warn: 'sc->max_qentries' unsigned <= 0
pci_nvme_parse_config() warn: 'sc->ioslots' unsigned <= 0

Because we are using atoi() to translate string to int, we need
to use int type variable for translation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Mon, Jul 13, 2:06 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMon, Jul 13, 2:06 PM

Herald added subscribers: dab, bcran, rgrimes, imp. · View Herald Transcript

tsoome requested review of this revision.Mon, Jul 13, 2:06 PM

Harbormaster completed remote builds in B74770: Diff 181907.Mon, Jul 13, 2:06 PM

bnovkov accepted this revision.Mon, Jul 13, 4:31 PM

This revision is now accepted and ready to land.Mon, Jul 13, 4:31 PM

Closed by commit rG575529a92d7b: bhyve: unsigned <= 0 (authored by tsoome). · Explain WhyMon, Jul 13, 7:17 PM

This revision was automatically updated to reflect the committed changes.

tsoome added a commit: rG575529a92d7b: bhyve: unsigned <= 0.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_nvme.c

16 lines

Diff 181925

View Options

bhyve: unsigned <= 0ClosedPublicActions