Page MenuHomeFreeBSD
Differential D5765

tcp/lro: Change SLIST to LIST, so that removing an entry from the list is O(1)
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Mar 28 2016, 1:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 3, 12:49 AM
Unknown Object (File)
Mon, Sep 29, 11:49 AM
Unknown Object (File)
Sun, Sep 28, 5:38 PM
Unknown Object (File)
Fri, Sep 19, 9:30 PM
Unknown Object (File)
Aug 30 2025, 10:54 AM
Unknown Object (File)
Jul 7 2025, 7:32 AM
Unknown Object (File)
Jul 4 2025, 12:20 PM
Unknown Object (File)
Jul 1 2025, 3:43 AM
View All 99 Files
Subscribers
None

Details

Reviewers
gallatin
howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
• hselasky
delphij
rrs
adrian
Group Reviewers
network
transport
Commits
rS297483: tcp/lro: Change SLIST to LIST, so that removing an entry is O(1)
Summary

This is kinda critical to the performance when the CPU is slow and network bandwidth is high, e.g. in the hypervisor.

e.g. in the Azure (1024 connections): Azure DS14 Azure G5

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 14665.Mar 28 2016, 1:50 AM
sepherosa_gmail.com retitled this revision from to tcp/lro: Change SLIST to LIST, so that removing an entry from the list is O(1).
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: network, gallatin, rrs, • hselasky, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
Herald added a reviewer: transport. · View Herald TranscriptMar 28 2016, 1:50 AM
sepherosa_gmail.com added inline comments.Mar 28 2016, 1:51 AM
sys/compat/linuxkpi/common/include/linux/list.h
64 ↗(On Diff #14665)

This one is used to unbreak the compilation of the Mallenox drivers. As observed by me and rrs@

decui_microsoft.com accepted this revision.Mar 28 2016, 4:47 AM
decui_microsoft.com edited edge metadata.
sepherosa_gmail.com updated this object.Mar 28 2016, 7:21 AM
sepherosa_gmail.com edited edge metadata.
rrs accepted this revision.Mar 28 2016, 9:19 AM
rrs edited edge metadata.

Nice.. this should help things.. especially if you add build on
this a hash table :-)

This revision is now accepted and ready to land.Mar 28 2016, 9:19 AM
gallatin accepted this revision.Mar 28 2016, 11:29 AM
gallatin edited edge metadata.

Very nice, thanks.

Closed by commit rS297483: tcp/lro: Change SLIST to LIST, so that removing an entry is O(1) (authored by sephe). · Explain WhyApr 1 2016, 6:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
compat/
linuxkpi/
common/
include/
linux/
1 line
netinet/
7 lines
43 lines

Diff 14800

View Options

head/sys/compat/linuxkpi/common/include/linux/list.h

Loading...
View Options

head/sys/netinet/tcp_lro.h

Loading...
View Options

head/sys/netinet/tcp_lro.c

Loading...