imgact_elf: handle unaligned phdrs
ClosedPublic
Actions

Authored by kib on Mon, Jun 8, 1:26 AM.

Details

Reviewers

emaste
jhb
markj
olce

Commits

rG0b269737f9ca: imgact_elf: handle unaligned phdrs

Summary

Althought non-compliant, there are binaries which have the phdrs placed
unaligned in the image.  Since we have the code to allocate memory for
off-page phdrs, the same code path can be used to handle unaligned
phdrs.

Relax the requirement for both the activated image and interpreter.

PR:     295629

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Mon, Jun 8, 1:26 AM

Herald added subscribers: olce, imp. · View Herald TranscriptMon, Jun 8, 1:26 AM

kib requested review of this revision.Mon, Jun 8, 1:26 AM

markj accepted this revision.Mon, Jun 8, 1:51 PM

This revision is now accepted and ready to land.Mon, Jun 8, 1:51 PM

emaste accepted this revision.Mon, Jun 8, 1:53 PM

Is printing a warning in this case useful, or not worth the trouble?

Is printing a warning in this case useful, or not worth the trouble?

I don't think so -- we should emit warnings or errors only for things that are actionable. For most users there's nothing for them to do with this information. Unless we imagine someone will see the warning, report an issue to the project responsible for the oddly-formatted binary, and then that project is going to fix their toolchain, we can just ignore it.

Closed by commit rG0b269737f9ca: imgact_elf: handle unaligned phdrs (authored by kib). · Explain WhyMon, Jun 8, 5:03 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG0b269737f9ca: imgact_elf: handle unaligned phdrs.