GCE: Fix sed command

[cperciva]

Summary

The command sed -i -e 's/foo/bar/' file treats '-e' as being the
suffix for '-i', creating a backup file named 'file-e'.

Fixes: 709c1049fe0c ("GCE: Fix growfs path")
MFC After: 1 day

[jrtc27]

Hm, this'll break if building on Linux... don't know if GCE is one of the ones for which that's now supported, probably not, but a bit sad to have this

[cperciva]

In D57422#1315672, @jrtc27 wrote:

Hm, this'll break if building on Linux... don't know if GCE is one of the ones for which that's now supported, probably not, but a bit sad to have this

Oh, I didn't know our VM image building code supported cross-building. That would explain why the original patch (which was submitted from Google) was wrong though.

[cperciva]

It's also brittle with pkgbase, FWIW.

[cperciva]

Just found @william.a_carrel.org 's phab account.

[ziaee]

release/tools/gce.conf

42

untested

[jrtc27]

In D57422#1315673, @cperciva wrote:

In D57422#1315672, @jrtc27 wrote:

Hm, this'll break if building on Linux... don't know if GCE is one of the ones for which that's now supported, probably not, but a bit sad to have this

Oh, I didn't know our VM image building code supported cross-building. That would explain why the original patch (which was submitted from Google) was wrong though.

In theory it mostly does thanks to -DNO_ROOT and -DWITHOUT_QEMU, though there might be other missing pieces. I know Brooks has an old branch for CheriBSD somewhere that does it, but there may be things that have yet to be cleaned up and merged (upstream and downstream, we're not building VM images).

[cperciva]

Actually, this is a completely harmless bug since the GCE images are built with NO_ROOT so the accidental /etc/rc.d/growfs-e file doesn't get distributed anyway.

This does need to get fixed properly though -- right now GCE images will stop running growfs the moment there's an update to the FreeBSD-rc package (including upgrading to a new release).