route_to: check_random: rely on test timeout to fail
ClosedPublic
Actions

Authored by siva on Wed, Jun 3, 3:35 PM.

Details

Reviewers

emaste
lwhsu
kp
ngie

Commits

rG1294f332aec0: tests/pf/route_to: check_random: rely on test timeout to fail

Summary

This test is known to be flaky if 10 attempts happens to be
not enough for the test to pass. Usually, this test passes in ~4-6 attempts.
See https://ci.freebsd.org/job/FreeBSD-main-amd64-test/28664/testReport/junit/sys.netpfil.pf/route_to/random_table/

Rely on the timeout (default 5 mins) to catch a failure here, rather than just 10
attempts. It's very unlikely that 5 mins worth of attempts still isn't enough.

For a history of flakiness, see
https://ci.freebsd.org/job/FreeBSD-main-amd64-test/lastSuccessfulBuild/testReport/junit/sys.netpfil.pf/route_to/random_table/history/

PR: 289477

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

siva created this revision.Wed, Jun 3, 3:35 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptWed, Jun 3, 3:35 PM

siva requested review of this revision.Wed, Jun 3, 3:35 PM

Harbormaster completed remote builds in B73639: Diff 179134.Wed, Jun 3, 3:35 PM

kp accepted this revision.Fri, Jun 5, 12:10 PM

This revision is now accepted and ready to land.Fri, Jun 5, 12:10 PM

ngie added inline comments.Sat, Jun 6, 1:43 AM

tests/sys/netpfil/pf/route_to.sh
50–52	Could you please add a comment to note that this infinite loop is intentional? It doesn't have to be overly verbose -- just to ensure that someone doesn't drop the change by accident. Also, should this have a short sleep to avoid burning a ton of CPU in this loop?