Page MenuHomeFreeBSD
Differential D57266

rtnetlink: Fix weight overflow in RTA_MULTIPATH
ClosedPublic
Actions

Authored by pouria on Wed, May 27, 10:03 AM.
Tags
None
Referenced Files
F158286187: D57266.id178733.diff
Sat, May 30, 7:23 PM
F158262295: D57266.id.diff
Sat, May 30, 12:50 PM
F158232064: D57266.diff
Sat, May 30, 2:57 AM
Unknown Object (File)
Fri, May 29, 7:45 AM
Subscribers
imp

Details

Reviewers
melifaro
glebius
markj
emaste
bz
Group Reviewers
network
Commits
rG97f7b21dd525: rtnetlink: Fix weight overflow in RTA_MULTIPATH
Summary

If the weight value is larger than 8 bits, set it to the maximum.
Also, only send RTA_WEIGHT if its value is not the default.
This reduces message size and matches the behavior of
non-multipath routes.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pouria created this revision.Wed, May 27, 10:03 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, May 27, 10:03 AM
pouria requested review of this revision.Wed, May 27, 10:03 AM
Harbormaster completed remote builds in B73471: Diff 178713.Wed, May 27, 10:03 AM
emaste added inline comments.Wed, May 27, 2:09 PM
sys/netlink/route/rt.c
220

Use MAX()?

pouria updated this revision to Diff 178733.Wed, May 27, 2:15 PM

Address @emaste comment.

Harbormaster completed remote builds in B73481: Diff 178733.Wed, May 27, 2:16 PM
markj added inline comments.Wed, May 27, 3:54 PM
sys/netlink/route/rt.c
246

Doesn't this break backwards compatibility? Or is this code new enough that it doesn't matter?

pouria marked an inline comment as done.Wed, May 27, 8:51 PM
pouria added inline comments.
sys/netlink/route/rt.c
246

This one is new.
I've added it in 84bb3648d2151 for backward compatibility with dump_rc_nhop. :D

emaste accepted this revision.Wed, May 27, 9:21 PM

Oops, MIN of course.

This revision is now accepted and ready to land.Wed, May 27, 9:21 PM
markj accepted this revision.Thu, May 28, 3:27 PM
Closed by commit rG97f7b21dd525: rtnetlink: Fix weight overflow in RTA_MULTIPATH (authored by pouria). · Explain WhyThu, May 28, 8:01 PM
This revision was automatically updated to reflect the committed changes.
pouria added a commit: rG97f7b21dd525: rtnetlink: Fix weight overflow in RTA_MULTIPATH.
pouria mentioned this in D56750: netlink: store osreldate of the process in the netlink pcb.Fri, May 29, 9:36 PM

Revision Contents
Changeset List

PathSize
sys/
netlink/
route/
5 lines

Diff 178850

View Options

sys/netlink/route/rt.c

Loading...