bq_insert: delay the BUF_UNLOCK if not bd_flush()ing
ClosedPublic
Actions

Authored by rlibby on Mon, May 11, 7:42 PM.

Tags

None

Referenced Files

	F157003402: D56948.diff
	Sun, May 17, 9:59 PM

	F157003382: D56948.diff
	Sun, May 17, 9:58 PM

	F157001724: D56948.diff
	Sun, May 17, 9:40 PM

	F156907433: D56948.diff
	Sun, May 17, 6:36 AM

	Unknown Object (File)
	Sat, May 16, 10:56 PM

	Unknown Object (File)
	Fri, May 15, 1:50 PM

	Unknown Object (File)
	Thu, May 14, 2:19 PM

	Unknown Object (File)
	Wed, May 13, 1:50 AM

View All 12 Files

Subscribers

imp

olce

Details

Reviewers

kib
markj
jeff

Commits

rG2a56cedac2e4: bq_insert: delay the BUF_UNLOCK if not bd_flush()ing

Summary

Reduce bufqueue lock contention by delaying the BUF_UNLOCK to after
dropping the bufqueue lock. Still do the early BUF_UNLOCK if we
actually have to bd_flush.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Mon, May 11, 7:42 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMon, May 11, 7:42 PM

rlibby requested review of this revision.Mon, May 11, 7:42 PM

Harbormaster completed remote builds in B72990: Diff 177600.Mon, May 11, 7:42 PM

rlibby added reviewers: kib, markj, jeff.Mon, May 11, 7:44 PM

kib accepted this revision.Mon, May 11, 7:48 PM

This revision is now accepted and ready to land.Mon, May 11, 7:48 PM

markj accepted this revision.Tue, May 12, 1:13 PM

Closed by commit rG2a56cedac2e4: bq_insert: delay the BUF_UNLOCK if not bd_flush()ing (authored by rlibby). · Explain WhyWed, May 13, 5:45 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG2a56cedac2e4: bq_insert: delay the BUF_UNLOCK if not bd_flush()ing.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_bio.c

20 lines

Diff 177797

View Options

bq_insert: delay the BUF_UNLOCK if not bd_flush()ingClosedPublicActions