packages: Fix clang conditional
AbandonedPublic
Actions

Authored by ivy on Apr 27 2026, 5:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 21, 11:45 AM

	Unknown Object (File)
	Sun, Sep 20, 6:10 AM

	Unknown Object (File)
	Thu, Sep 10, 3:19 AM

	Unknown Object (File)
	Thu, Sep 10, 12:06 AM

	Unknown Object (File)
	Wed, Sep 9, 11:42 PM

	Unknown Object (File)
	Wed, Sep 9, 6:09 PM

	Unknown Object (File)
	Wed, Sep 2, 10:29 PM

	Unknown Object (File)
	Mon, Aug 31, 2:59 PM

View All 46 Files

Subscribers

imp

Details

Reviewers

emaste

Group Reviewers

pkgbase

Summary

Various src.conf options can cause us to build something that ends up
in the clang package, but MK_TOOLCHAIN is not one of them; copy the
proper conditional from lib/Makefile to decide if we need to build
the package.

This fixes the build when LLVM/clang is entirely disabled.

Fixes: bb75b0d581f7 ("packages: Convert world to a subdir build")
MFC after: 2 weeks
Sponsored by: https://www.patreon.com/bsdivy

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72578
Build 69461: arc lint + arc unit

Event Timeline

ivy created this revision.Apr 27 2026, 5:45 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 27 2026, 5:45 PM

ivy requested review of this revision.Apr 27 2026, 5:45 PM

Harbormaster completed remote builds in B72578: Diff 176653.Apr 27 2026, 5:45 PM

emaste accepted this revision.Apr 27 2026, 5:47 PM

This revision is now accepted and ready to land.Apr 27 2026, 5:47 PM

accidentally opened a duplicate review for this (D56657 is the right one), sorry.

Revision Contents
Changeset List

Path

Size

packages/

Makefile

3 lines

Diff 176653

View Options

packages: Fix clang conditionalAbandonedPublicActions