Paths

Table of Contentst

Differential D56609

tests: Add a test for races between between if_detach() and vnet_if_return()
ClosedPublic
Actions

Authored by zlei on Thu, Apr 23, 8:58 PM.

Tags

None

Referenced Files

	F157082753: D56609.diff
	Mon, May 18, 8:22 AM

	F157081978: D56609.diff
	Mon, May 18, 8:18 AM

	Unknown Object (File)
	Tue, May 12, 10:30 PM

	Unknown Object (File)
	Tue, May 12, 2:48 PM

	Unknown Object (File)
	Tue, May 12, 6:51 AM

	Unknown Object (File)
	Mon, May 11, 11:38 PM

	Unknown Object (File)
	Fri, May 8, 4:11 PM

	Unknown Object (File)
	Thu, May 7, 12:58 PM

View All 23 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG33da0a256bfc: tests/netgraph: Add a test for races between if_detach() and vnet_if_return()
rG3a4c4d61ac2c: tests/netgraph: Add a test for races between if_detach() and vnet_if_return()
rG0988abd52352: tests/netgraph: Add a test for races between if_detach() and vnet_if_return()

Summary

ng_eiface(4) or physical interfaces does not involve cloner hence the
detaching is a bit different with epair(4). Add more tests to cover
that.

PR: 292993
MFC after: 5 days

Test Plan

Run against stable/15 and stable/14, with / without D56374 .

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Thu, Apr 23, 8:58 PM

Herald added subscribers: glebius, melifaro, donner, imp. · View Herald TranscriptThu, Apr 23, 8:58 PM

zlei requested review of this revision.Thu, Apr 23, 8:58 PM

zlei mentioned this in D56374: ifnet: if_detach(): Fix races with if_vmove().Thu, Apr 23, 9:04 PM

zlei added inline comments.Thu, Apr 23, 9:13 PM

tests/sys/netgraph/eiface_test.sh
33	`tests/ci/tools/ci.conf` exists on CURRENT and stable/15 to load the required modules, but not on stable/14. Shall load required modules in the test case ?

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Apr 27, 7:21 PM

Closed by commit rG0988abd52352: tests/netgraph: Add a test for races between if_detach() and vnet_if_return() (authored by zlei). · Explain Why

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG0988abd52352: tests/netgraph: Add a test for races between if_detach() and vnet_if_return().

zlei added inline comments.Mon, Apr 27, 7:26 PM

tests/sys/netgraph/eiface_test.sh
33	`tests/ci/tools/ci.conf` exists on CURRENT and stable/15 to load the required modules, but not on stable/14. Shall load required modules in the test case ? Indeed `ngctl(8)` and `ng_socket(4)` will load required modules on demand. No need to bother `tests/ci/tools/ci.conf` for this testcase.

zlei added a commit: rG3a4c4d61ac2c: tests/netgraph: Add a test for races between if_detach() and vnet_if_return().Thu, Apr 30, 9:54 AM

zlei added a commit: rG33da0a256bfc: tests/netgraph: Add a test for races between if_detach() and vnet_if_return().Mon, May 4, 4:51 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

netgraph/

2 lines

67 lines

Diff 176665

tests/sys/netgraph/Makefile

Loading...

tests/sys/netgraph/eiface_test.sh

Loading...