route.8: Describe weight modifier
AcceptedPublic
Actions

Authored by pouria on Fri, Apr 3, 6:57 PM.

Details

Reviewers

ziaee
markj
zlei
glebius

Group Reviewers

manpages
network

Summary

Add and describe -weight argument
to the manual.

Test Plan

mandoc -Tlint

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 72198
Build 69081: arc lint + arc unit

Event Timeline

pouria created this revision.Fri, Apr 3, 6:57 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Apr 3, 6:57 PM

pouria requested review of this revision.Fri, Apr 3, 6:57 PM

Harbormaster completed remote builds in B71948: Diff 174883.Fri, Apr 3, 6:57 PM

markj added inline comments.Sat, Apr 4, 10:45 AM

sbin/route/route.8
309	(I am not familiar with how this actually works.) What does "twice as likely" mean? Where does the weight actually get evaluated?

I want to work on metric or administrative distance too.
But I'm waiting on @melifaro response to some of my questions.

sbin/route/route.8

309

sys/net/route/nhgrp_ctl.c:233:

224 /*
225  * Compile actual list of nexthops to be used by datapath from
226  *  the nexthop group @dst.
227  *
228  * For example, compiling control plane list of 2 nexthops
229  *  [(200, A), (100, B)] would result in the datapath array
230  *  [A, A, B]
231  */

IMHO, the description is good enough and clear. Later, native-speakers-doc-committers can improve.

This revision is now accepted and ready to land.Sun, Apr 12, 7:35 PM

kind ping @ziaee

Thanks for the ping!

sbin/route/route.8
306	I don't know how this works. It's rendering as: -gateway -3fff::1 -weight -100 Is that correct? Seems like the IP addresses aren't usually a flag?

@ziaee done.

This revision now requires review to proceed.Tue, Apr 14, 7:54 AM

Harbormaster completed remote builds in B72189: Diff 175478.Tue, Apr 14, 7:54 AM

pouria added inline comments.Tue, Apr 14, 7:54 AM

sbin/route/route.8
306	You're right. I should prefix it with Li tag. Now it should be: -gateway 3fff::1 -weight 100

ziaee added inline comments.Tue, Apr 14, 1:48 PM

sbin/route/route.8
306	Prefixing with Li makes it look `like this` when rendered to things other than terminal. I think they are arguments to the flag, so should use Ar probably.

@ziaee done.

Harbormaster completed remote builds in B72196: Diff 175503.Tue, Apr 14, 1:58 PM

ziaee added inline comments.Tue, Apr 14, 2:13 PM

sbin/route/route.8
306	What do you think of if we did them like this? My rule is, if the page uses Ql, then use that, and if it uses Dq, then I try to use that. We have some other Dq's on the page. It bloats the lines a bit, but I think it kinda looks nice.