Page MenuHomeFreeBSD

uart/ns8250: fix Alder Lake AMT SOL getting stuck during probe
ClosedPublic

Authored by royger on Thu, Mar 26, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 30, 11:50 AM
Unknown Object (File)
Mon, Mar 30, 9:02 AM
Unknown Object (File)
Mon, Mar 30, 2:23 AM
Unknown Object (File)
Sun, Mar 29, 4:22 PM
Unknown Object (File)
Fri, Mar 27, 12:56 AM
Subscribers
None

Details

Reviewers
marcel
imp
Summary

When the Alder Lake Serial-over-LAN device is put into loopback mode and
repeated writes are performed to the data register it results in the device
ending up in a broken state.

The way to recover the device requires draining the Receiver queue ahead of
waiting for the device to drain it's transmit queue. Doing in that
specific order fixes the device. Also note that the draining and flushing
of the queues should better be done unconditionally, hence place it inside
the describe label so it's also done when exiting early from the FIFO
length testing loop.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

royger created this revision.
This revision is now accepted and ready to land.Fri, Mar 27, 3:25 AM

This has been superseded by https://reviews.freebsd.org/D56107 which is simpler and also solves the issue. Closing the revision now.