snd_uaudio: Introduce umidi_probe()
AbandonedPublic
Actions

Authored by christos on Tue, Mar 17, 6:36 PM.

Details

Reviewers

markj
emaste
meka_tilda.center

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71464
Build 68347: arc lint + arc unit

Event Timeline

christos created this revision.Tue, Mar 17, 6:36 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Mar 17, 6:36 PM

christos requested review of this revision.Tue, Mar 17, 6:36 PM

Harbormaster completed remote builds in B71464: Diff 173818.Tue, Mar 17, 6:36 PM

christos added a parent revision: D55900: snd_uaudio: Rename umidi_probe() to umidi_attach().Tue, Mar 17, 6:36 PM

christos added a child revision: D55902: snd_uaudio: Merge umidi_init() with umidi_attach().

markj added inline comments.Thu, Mar 19, 8:15 AM

sys/dev/sound/usb/uaudio.c
876	Shouldn't this check be first? What if one of these devices belongs to the audiocontrol subclass?

christos abandoned this revision.Thu, Mar 19, 12:21 PM

christos added inline comments.

sys/dev/sound/usb/uaudio.c
876	To be perfectly honest, I'm not sure. I think we can abandon this for now so as to not cause some accidental side-effect.

christos mentioned this in D55916: snd_uaudio: Simplify umidi_probe().Thu, Mar 19, 12:33 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

usb/

uaudio.c

32 lines

Diff 173818

View Options

sys/dev/sound/usb/uaudio.c

snd_uaudio: Introduce umidi_probe()AbandonedPublicActions