Page MenuHomeFreeBSD
Differential D55901

snd_uaudio: Introduce umidi_probe()
AbandonedPublic
Actions

Authored by christos on Mar 17 2026, 6:36 PM.
Tags
None
Referenced Files
F161677319: D55901.diff
Sun, Jul 5, 9:11 PM
Unknown Object (File)
Wed, Jun 17, 5:51 AM
Unknown Object (File)
May 30 2026, 12:21 AM
Unknown Object (File)
May 17 2026, 9:23 PM
Unknown Object (File)
May 17 2026, 9:17 PM
Unknown Object (File)
May 17 2026, 5:31 PM
Unknown Object (File)
May 17 2026, 5:30 PM
Unknown Object (File)
May 10 2026, 6:00 AM
View All 27 Files
Subscribers
imp

Details

Reviewers
markj
emaste
meka_tilda.center
Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71464
Build 68347: arc lint + arc unit

Event Timeline

christos created this revision.Mar 17 2026, 6:36 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 17 2026, 6:36 PM
christos requested review of this revision.Mar 17 2026, 6:36 PM
Harbormaster completed remote builds in B71464: Diff 173818.Mar 17 2026, 6:36 PM
christos added a parent revision: D55900: snd_uaudio: Rename umidi_probe() to umidi_attach().Mar 17 2026, 6:36 PM
christos added a child revision: D55902: snd_uaudio: Refactor umidi_attach().
markj added inline comments.Mar 19 2026, 8:15 AM
sys/dev/sound/usb/uaudio.c
876

Shouldn't this check be first? What if one of these devices belongs to the audiocontrol subclass?

christos abandoned this revision.Mar 19 2026, 12:21 PM
christos added inline comments.
sys/dev/sound/usb/uaudio.c
876

To be perfectly honest, I'm not sure. I think we can abandon this for now so as to not cause some accidental side-effect.

christos mentioned this in D55916: snd_uaudio: Simplify umidi_probe().Mar 19 2026, 12:33 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
usb/
32 lines

Diff 173818

View Options

sys/dev/sound/usb/uaudio.c

Loading...