ip6_mroute: Make MF6CFIND a regular function
ClosedPublic
Actions

Authored by markj on Fri, Jan 30, 8:51 PM.

Details

Reviewers

glebius

Group Reviewers

network

Commits

rGb370fcc716b9: ip6_mroute: Make MF6CFIND a regular function

Summary

This is more natural and corresponds more closely to the v4 multicast
routing code. No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Fri, Jan 30, 8:51 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptFri, Jan 30, 8:51 PM

markj requested review of this revision.Fri, Jan 30, 8:51 PM

Harbormaster completed remote builds in B70253: Diff 170810.Fri, Jan 30, 8:51 PM

markj added a parent revision: D54982: ip_mroute: Make privilege checking more consistent.Fri, Jan 30, 8:51 PM

glebius accepted this revision as: glebius.Fri, Jan 30, 9:38 PM

glebius added inline comments.

sys/netinet6/ip6_mroute.c
350	I'd suggest to use more meaningful names like `origin` and `group`, or `orig` and `grp`.

This revision is now accepted and ready to land.Fri, Jan 30, 9:38 PM

markj marked an inline comment as done.Fri, Jan 30, 9:40 PM

markj added inline comments.

sys/netinet6/ip6_mroute.c
350	Sure, I made the change locally.

Closed by commit rGb370fcc716b9: ip6_mroute: Make MF6CFIND a regular function (authored by markj). · Explain WhyMon, Feb 2, 4:56 PM

This revision was automatically updated to reflect the committed changes.

markj marked an inline comment as done.

markj added a commit: rGb370fcc716b9: ip6_mroute: Make MF6CFIND a regular function.

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

ip6_mroute.c

45 lines

Diff 170996

View Options

ip6_mroute: Make MF6CFIND a regular functionClosedPublicActions