Differential D54973

e1000: Fix setting the promiscuous mode
ClosedPublic
Actions

Authored by zlei on Fri, Jan 30, 4:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 3, 11:51 AM

	Unknown Object (File)
	Tue, Feb 3, 6:07 AM

	Unknown Object (File)
	Sat, Jan 31, 8:13 AM

	Unknown Object (File)
	Sat, Jan 31, 6:40 AM

	Unknown Object (File)
	Sat, Jan 31, 4:09 AM

	Unknown Object (File)
	Sat, Jan 31, 3:42 AM

	Unknown Object (File)
	Sat, Jan 31, 3:04 AM

	Unknown Object (File)
	Fri, Jan 30, 11:17 PM

View All 9 Files

Subscribers

Details

Reviewers

kbowling
kgalazka
markj

Group Reviewers

network
Restricted Owners Package	(Owns No Changed Paths)

Commits

rGe63ee5fedb8d: e1000: Fix setting the promiscuous mode

Summary

The variable reg_rctl stores the value read from reg E1000_RCTL. It
may contains bits E1000_RCTL_VFE and E1000_RCTL_CFIEN which
control VLAN hardware filter feature. The promiscuous mode implies
all tagged or untagged packets should be accepted, so the VLAN
hardware filter feature should be disabled. Calling em_if_vlan_filter_disable()
did this, but later writing the value of reg_rctl back to the reg E1000_RCTL
may restore the feature.

Move the calling of em_if_vlan_filter_disable() after writing the reg to fix that.

PR: 292759
Tested by: vova@zote.me
Fixes: 2796f7cab107 e1000: Fix up HW vlan ops
MFC after: 5 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Fri, Jan 30, 4:15 PM

Owners added a reviewer: Restricted Owners Package.Fri, Jan 30, 4:15 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jan 30, 4:15 PM

zlei requested review of this revision.Fri, Jan 30, 4:15 PM

zlei edited the summary of this revision. (Show Details)Fri, Jan 30, 5:46 PM

kbowling accepted this revision.Sun, Feb 1, 5:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Feb 2, 12:29 PM

Closed by commit rGe63ee5fedb8d: e1000: Fix setting the promiscuous mode (authored by zlei). · Explain Why

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGe63ee5fedb8d: e1000: Fix setting the promiscuous mode.

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

2 lines

Diff 170976

sys/dev/e1000/if_em.c

Loading...