virtio: Use bus_dma for ring and indirect buffer allocations
Needs ReviewPublic
Actions

Authored by sarah.walker2_arm.com on Fri, Jan 30, 11:14 AM.

Details

Reviewers

bryanv
andrew

Summary

While the majority of virtio platforms will be fully coherent, some may
require cache maintenance or other specific device memory handling (eg for
secure partitioning). Using bus_dma allows for these usecases.

The virtio buffers are marked as coherent; this should ensure that sync
calls are no-ops in the common cases.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70227
Build 67110: arc lint + arc unit

Event Timeline

sarah.walker2_arm.com created this revision.Fri, Jan 30, 11:14 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jan 30, 11:14 AM

sarah.walker2_arm.com requested review of this revision.Fri, Jan 30, 11:14 AM

Harbormaster completed remote builds in B70227: Diff 170769.Fri, Jan 30, 11:14 AM

sarah.walker2_arm.com added a child revision: D54960: virtio_blk: Use bus_dma for command/ack buffer allocations.Fri, Jan 30, 11:14 AM

andrew added reviewers: bryanv, andrew.Mon, Feb 2, 5:42 PM

emaste added a subscriber: emaste.Tue, Feb 3, 5:23 PM

Do we still need the mb()s? I would expect bus_dmamap_sync to suffice.

virtio_blk calls bus_dma_tag_set_iommu on PowerPC; would that not be needed for these new tags?

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

virtio_ring.h

27 lines

virtqueue.c

196 lines

Diff 170769

View Options

sys/dev/virtio/virtio_ring.h