Paged/pageable data is not always paged.

[tsoome]

Summary

This is another bit of work I have actually done on loader port on illumos
and pushing to fbsd.

The loader is using pager api to represent some data, enabling users
actually to view information, before it will be scrolled out of the screen.
This update adds more pager support for disk devices and implements
pager setup for few commands, which are missing this feature; notably
memmap/nvram for loader.efi. Note the EFI variables will actually need
more work to present the values, I think that would be outside the scope
of this update, however.

Test Plan

For simple test, verify the output of the loader commands.
For better test, one would need more elaborate environment, with more
disk devices, more partitions and more/complex zfs pools for lsdev -v
to verify the screen updates.

[tsoome]

nvram commad was still buggy, wrong arguments used to initiate
the enumeration.

[allanjude]

sys/boot/common/dev_net.c

351–356

in order to avoid overflowing 80 character screen width, would it be better to use 8 spaces here rather than a tab?

[tsoome]

update against revision 296323.

[tsoome]

Updated to revision 296425.

[tsoome]

Updated to revision 298256.

[tsoome]

Updated to revision 298624.

[tsoome]

Updated to revision 298901.

[tsoome]

Updated to revision 301442.

[allanjude]

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:354:12: error: unused variable 'ret' [-Werror,-Wunused-variable]

int unit, ret;
          ^

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:369:1: error: control reaches end of non-void function [-Werror,-Wreturn-type]

This problem is present in a large number of the modified functions

sys/boot/efi/libefi/efinet.c

340

this function has no return value, and ret is unused

sys/boot/efi/libefi/efipart.c

201

no return, ret unused

sys/boot/i386/libi386/bioscd.c

194

no return, ret unused

[imp]

I deleted the nvram command since it was replaced by useful in scripting commands that also worked in interactive mode. Why is it back?

sys/boot/efi/loader/main.c

683

I thought I wrote commands that make this command no longer necessary and deleted it.

[allanjude]

sys/boot/common/part.c

862–864

ret is unused here

[tsoome]

In D5461#153258, @imp wrote:

I deleted the nvram command since it was replaced by useful in scripting commands that also worked in interactive mode. Why is it back?

yep, this diff is just that old, I need to review it and clean up properly - just wanted to get few others our of the queue first:)

[tsoome]

svn update, resync with updates since initial version.

[tsoome]

In D5461#153250, @allanjude wrote:

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:354:12: error: unused variable 'ret' [-Werror,-Wunused-variable]

int unit, ret;
          ^

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:369:1: error: control reaches end of non-void function [-Werror,-Wreturn-type]

This problem is present in a large number of the modified functions

In D5461#153250, @allanjude wrote:

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:354:12: error: unused variable 'ret' [-Werror,-Wunused-variable]

int unit, ret;
          ^

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:369:1: error: control reaches end of non-void function [-Werror,-Wreturn-type]

This problem is present in a large number of the modified functions

yes, it was issue popped up after svn update, the merges were gone bad. I think I have resolved those now.

[tsoome]

Updated to revision 308195.

[tsoome]

In D5461#153250, @allanjude wrote:

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:354:12: error: unused variable 'ret' [-Werror,-Wunused-variable]

int unit, ret;
          ^

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:369:1: error: control reaches end of non-void function [-Werror,-Wreturn-type]

This problem is present in a large number of the modified functions

In D5461#153250, @allanjude wrote:

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:354:12: error: unused variable 'ret' [-Werror,-Wunused-variable]

int unit, ret;
          ^

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:369:1: error: control reaches end of non-void function [-Werror,-Wreturn-type]

This problem is present in a large number of the modified functions

yes, it was issue popped up after svn update, the merges were gone bad. I think I have resolved those now.

[tsoome]

sys/boot/common/dev_net.c

351–356

But tab is expanded to 8 spaces anyhow on console emulator. Or did I misunderstood you there?

[allanjude]

You have tested this? if so: Approved for commit

sys/boot/common/dev_net.c

351–356

You can ignore this comment. I figured the \t was only counted as a single character.