Page MenuHomeFreeBSD
Differential D5461

Paged/pageable data is not always paged.
ClosedPublic
Actions

Authored by tsoome on Feb 26 2016, 11:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 10:35 AM
Unknown Object (File)
Sun, Apr 7, 9:48 AM
Unknown Object (File)
Sun, Apr 7, 7:51 AM
Unknown Object (File)
Sun, Apr 7, 7:00 AM
Unknown Object (File)
Mar 27 2024, 4:56 PM
Unknown Object (File)
Mar 17 2024, 11:01 AM
Unknown Object (File)
Mar 17 2024, 3:55 AM
Unknown Object (File)
Mar 9 2024, 8:11 AM
View All Files
Subscribers
allanjude
delphij
imp
rpokala
Contributor Reviews (src)

Details

Reviewers
emaste
allanjude
imp
smh
Group Reviewers
Contributor Reviews (src)
Commits
rS308434: Loader paged/pageable data is not always paged.
Summary

This is another bit of work I have actually done on loader port on illumos
and pushing to fbsd.

The loader is using pager api to represent some data, enabling users
actually to view information, before it will be scrolled out of the screen.
This update adds more pager support for disk devices and implements
pager setup for few commands, which are missing this feature; notably
memmap/nvram for loader.efi. Note the EFI variables will actually need
more work to present the values, I think that would be outside the scope
of this update, however.

Test Plan

For simple test, verify the output of the loader commands.
For better test, one would need more elaborate environment, with more
disk devices, more partitions and more/complex zfs pools for lsdev -v
to verify the screen updates.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tsoome updated this revision to Diff 13790.Feb 26 2016, 11:36 AM
tsoome retitled this revision from to Paged/pageable data in not always paged..
tsoome updated this object.
tsoome edited the test plan for this revision. (Show Details)
Herald added subscribers: Contributor Reviews (src), rpokala, delphij, imp. · View Herald TranscriptFeb 26 2016, 11:36 AM
tsoome updated this revision to Diff 13794.Feb 26 2016, 2:10 PM

nvram commad was still buggy, wrong arguments used to initiate
the enumeration.

allanjude added a subscriber: allanjude.Feb 26 2016, 5:30 PM
allanjude added inline comments.
sys/boot/common/dev_net.c
347 ↗(On Diff #13794)

in order to avoid overflowing 80 character screen width, would it be better to use 8 spaces here rather than a tab?

tsoome updated this revision to Diff 14000.Mar 2 2016, 9:03 PM

update against revision 296323.

tsoome added a reviewer: Contributor Reviews (src).Mar 2 2016, 9:05 PM
tsoome updated this revision to Diff 14113.Mar 6 2016, 10:25 AM

Updated to revision 296425.

tsoome updated this revision to Diff 15308.Apr 19 2016, 6:42 AM

Updated to revision 298256.

tsoome updated this revision to Diff 15616.Apr 26 2016, 11:07 AM

Updated to revision 298624.

tsoome updated this revision to Diff 15800.May 1 2016, 9:26 PM

Updated to revision 298901.

allanjude added reviewers: emaste, imp, smh.May 1 2016, 9:41 PM
tsoome updated this revision to Diff 17326.Jun 5 2016, 12:29 PM

Updated to revision 301442.

tsoome retitled this revision from Paged/pageable data in not always paged. to Paged/pageable data is not always paged..Jun 6 2016, 11:08 AM
allanjude requested changes to this revision.Jul 30 2016, 6:19 PM
allanjude added a reviewer: allanjude.

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:354:12: error: unused variable 'ret' [-Werror,-Wunused-variable]

int unit, ret;
          ^

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:369:1: error: control reaches end of non-void function [-Werror,-Wreturn-type]

This problem is present in a large number of the modified functions

sys/boot/efi/libefi/efinet.c
369 ↗(On Diff #17326)

this function has no return value, and ret is unused

sys/boot/efi/libefi/efipart.c
190 ↗(On Diff #17326)

no return, ret unused

sys/boot/i386/libi386/bioscd.c
194 ↗(On Diff #17326)

no return, ret unused

This revision now requires changes to proceed.Jul 30 2016, 6:19 PM
imp edited edge metadata.Jul 30 2016, 6:27 PM

I deleted the nvram command since it was replaced by useful in scripting commands that also worked in interactive mode. Why is it back?

sys/boot/efi/loader/main.c
744 ↗(On Diff #17326)

I thought I wrote commands that make this command no longer necessary and deleted it.

allanjude added inline comments.Jul 30 2016, 6:41 PM
sys/boot/common/part.c
863 ↗(On Diff #17326)

ret is unused here

tsoome added a comment.Jul 30 2016, 7:01 PM
In D5461#153258, @imp wrote:

I deleted the nvram command since it was replaced by useful in scripting commands that also worked in interactive mode. Why is it back?

yep, this diff is just that old, I need to review it and clean up properly - just wanted to get few others our of the queue first:)

tsoome updated this revision to Diff 21926.Nov 2 2016, 6:16 AM
tsoome edited edge metadata.

svn update, resync with updates since initial version.

tsoome added a comment.Nov 2 2016, 6:21 AM
In D5461#153250, @allanjude wrote:

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:354:12: error: unused variable 'ret' [-Werror,-Wunused-variable]

int unit, ret;
          ^

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:369:1: error: control reaches end of non-void function [-Werror,-Wreturn-type]

This problem is present in a large number of the modified functions

In D5461#153250, @allanjude wrote:

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:354:12: error: unused variable 'ret' [-Werror,-Wunused-variable]

int unit, ret;
          ^

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:369:1: error: control reaches end of non-void function [-Werror,-Wreturn-type]

This problem is present in a large number of the modified functions

yes, it was issue popped up after svn update, the merges were gone bad. I think I have resolved those now.

tsoome updated this revision to Diff 21928.Nov 2 2016, 6:40 AM
tsoome edited edge metadata.

Updated to revision 308195.

tsoome marked 5 inline comments as done.Nov 2 2016, 8:54 AM
In D5461#153250, @allanjude wrote:

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:354:12: error: unused variable 'ret' [-Werror,-Wunused-variable]

int unit, ret;
          ^

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:369:1: error: control reaches end of non-void function [-Werror,-Wreturn-type]

This problem is present in a large number of the modified functions

In D5461#153250, @allanjude wrote:

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:354:12: error: unused variable 'ret' [-Werror,-Wunused-variable]

int unit, ret;
          ^

/media/svn/tsoome/head/sys/boot/efi/libefi/efinet.c:369:1: error: control reaches end of non-void function [-Werror,-Wreturn-type]

This problem is present in a large number of the modified functions

yes, it was issue popped up after svn update, the merges were gone bad. I think I have resolved those now.

tsoome added inline comments.Nov 7 2016, 8:33 PM
sys/boot/common/dev_net.c
347 ↗(On Diff #13794)

But tab is expanded to 8 spaces anyhow on console emulator. Or did I misunderstood you there?

allanjude accepted this revision.Nov 7 2016, 8:38 PM
allanjude edited edge metadata.

You have tested this? if so: Approved for commit

sys/boot/common/dev_net.c
347 ↗(On Diff #13794)

You can ignore this comment. I figured the \t was only counted as a single character.

This revision is now accepted and ready to land.Nov 7 2016, 8:38 PM
Closed by commit rS308434: Loader paged/pageable data is not always paged. (authored by tsoome). · Explain WhyNov 8 2016, 6:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lib/
libstand/
2 lines
sys/
boot/
common/
12 lines
18 lines
8 lines
2 lines
3 lines
efi/
libefi/
11 lines
21 lines
loader/
31 lines
i386/
libfirewire/
13 lines
libi386/
13 lines
20 lines
16 lines
mips/
beri/
loader/
16 lines
14 lines
ofw/
libofw/
6 lines
pc98/
libpc98/
11 lines
29 lines
powerpc/
kboot/
6 lines
ps3/
5 lines
5 lines
uboot/
lib/
17 lines
usb/
storage/
11 lines
userboot/
userboot/
6 lines
20 lines
zfs/
13 lines
71 lines

Diff 22076

View Options

head/lib/libstand/stand.h

Loading...
View Options

head/sys/boot/common/dev_net.c

Loading...
View Options

head/sys/boot/common/module.c

Loading...
View Options

head/sys/boot/common/part.c

Loading...
View Options

head/sys/boot/common/util.h

Loading...
View Options

head/sys/boot/common/util.c

Loading...
View Options

head/sys/boot/efi/libefi/efinet.c

Loading...
View Options

head/sys/boot/efi/libefi/efipart.c

Loading...
View Options

head/sys/boot/efi/loader/main.c

Loading...
View Options

head/sys/boot/i386/libfirewire/firewire.c

Loading...
View Options

head/sys/boot/i386/libi386/bioscd.c

Loading...
View Options

head/sys/boot/i386/libi386/biosdisk.c

Loading...
View Options

head/sys/boot/i386/libi386/pxe.c

Loading...
View Options

head/sys/boot/mips/beri/loader/beri_disk_cfi.c

Loading...
View Options

head/sys/boot/mips/beri/loader/beri_disk_sdcard.c

Loading...
View Options

head/sys/boot/ofw/libofw/ofw_disk.c

Loading...
View Options

head/sys/boot/pc98/libpc98/bioscd.c

Loading...
View Options

head/sys/boot/pc98/libpc98/biosdisk.c

Loading...
View Options

head/sys/boot/powerpc/kboot/hostdisk.c

Loading...
View Options

head/sys/boot/powerpc/ps3/ps3cdrom.c

Loading...
View Options

head/sys/boot/powerpc/ps3/ps3disk.c

Loading...
View Options

head/sys/boot/uboot/lib/disk.c

Loading...
View Options

head/sys/boot/usb/storage/umass_loader.c

Loading...
View Options

head/sys/boot/userboot/userboot/host.c

Loading...
View Options

head/sys/boot/userboot/userboot/userboot_disk.c

Loading...
View Options

head/sys/boot/zfs/zfs.c

Loading...
View Options

head/sys/boot/zfs/zfsimpl.c

Loading...