bnxt: don't set media status if link is down
ClosedPublic
Actions

Authored by anaelle.cazuc_stormshield.eu on Jan 7 2026, 9:43 AM.

Details

Reviewers

shurd
zlei
pouria

Group Reviewers

network

Commits

rG79c748ed4343: bnxt: don't set media status if link is down
rG69de2b4e9679: bnxt: don't set media status if link is down

Summary

When the link is down we shouldn't set flags other than IFM_AVALID & IFM_ETHER
This avoids media: Ethernet autoselect (Unknown <full-duplex>) on ifconfig

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

anaelle.cazuc_stormshield.eu created this revision.Jan 7 2026, 9:43 AM

Herald added a reviewer: shurd. · View Herald TranscriptJan 7 2026, 9:43 AM

Herald added a subscriber: imp. · View Herald Transcript

anaelle.cazuc_stormshield.eu requested review of this revision.Jan 7 2026, 9:43 AM

A branch is available on github to ease merge: https://github.com/stormshield-acazuc/freebsd-src/tree/bnxt_media

anaelle.cazuc_stormshield.eu added a reviewer: network.Jan 26 2026, 12:56 PM

Looks good to me.

This revision is now accepted and ready to land.Jan 26 2026, 1:39 PM

@glebius Can I commit it with a 1-week MFC?

In D54573#1255018, @pouria wrote:

@glebius Can I commit it with a 1-week MFC?

Yes, approved. Thanks!

Closed by commit rG69de2b4e9679: bnxt: don't set media status if link is down (authored by anaelle.cazuc_stormshield.eu, committed by pouria). · Explain WhyJan 26 2026, 11:24 PM

This revision was automatically updated to reflect the committed changes.

pouria added a commit: rG69de2b4e9679: bnxt: don't set media status if link is down.

pouria added a commit: rG79c748ed4343: bnxt: don't set media status if link is down.Tue, Feb 3, 9:35 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

bnxt/

bnxt_en/

if_bnxt.c

7 lines

Diff 170503

View Options

sys/dev/bnxt/bnxt_en/if_bnxt.c

bnxt: don't set media status if link is downClosedPublicActions