bnxt: don't set media status if link is down
Needs ReviewPublic
Actions

Authored by aurelien.cazuc.external_stormshield.eu on Wed, Jan 7, 9:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 15, 12:46 AM

	Unknown Object (File)
	Tue, Jan 13, 11:36 PM

	Unknown Object (File)
	Tue, Jan 13, 5:20 AM

	Unknown Object (File)
	Mon, Jan 12, 6:55 PM

	Unknown Object (File)
	Mon, Jan 12, 5:37 AM

	Unknown Object (File)
	Sat, Jan 10, 4:27 AM

	Unknown Object (File)
	Fri, Jan 9, 1:18 PM

	Unknown Object (File)
	Fri, Jan 9, 7:03 AM

View All 11 Files

Subscribers

imp

Details

Reviewers

shurd

Summary

When the link is down we shouldn't set flags other than IFM_AVALID & IFM_ETHER
This avoids media: Ethernet autoselect (Unknown <full-duplex>) on ifconfig

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

aurelien.cazuc.external_stormshield.eu created this revision.Wed, Jan 7, 9:43 AM

Herald added a reviewer: shurd. · View Herald TranscriptWed, Jan 7, 9:43 AM

Herald added a subscriber: imp. · View Herald Transcript

aurelien.cazuc.external_stormshield.eu requested review of this revision.Wed, Jan 7, 9:43 AM

A branch is available on github to ease merge: https://github.com/stormshield-acazuc/freebsd-src/tree/bnxt_media

Revision Contents
Changeset List

Path

Size

sys/

dev/

bnxt/

bnxt_en/

if_bnxt.c

7 lines

Diff 169232

View Options

sys/dev/bnxt/bnxt_en/if_bnxt.c

bnxt: don't set media status if link is downNeeds ReviewPublicActions