tcp: Unifidef use of rss software hash in syncache
ClosedPublic
Actions

Authored by gallatin on Mon, Jan 5, 7:38 PM.

Details

Reviewers

glebius
tuexen
pouria
nickbanks_netflix.com

Group Reviewers

transport

Commits

rG21865c970888: tcp: Unifidef use of rss software hash in syncache

Summary

Ever since "d9c55b2e8cd6 rss: Enable portions of RSS globally.."
exposed the RSS software hashing functions, it has been possible
to use them without "ifdef RSS". Do so now in the syncache
so as to get flowids recorded.

Note that the use of the rss hash functions is conditional on IP versions,
so we must ifdef INET to ensure rss_proto_software_hash_v4() is available.

Fixes 73fe85e486d2

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gallatin created this revision.Mon, Jan 5, 7:38 PM

Herald added a reviewer: transport. · View Herald TranscriptMon, Jan 5, 7:38 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

gallatin requested review of this revision.Mon, Jan 5, 7:38 PM

Thanks!

tuexen accepted this revision.Mon, Jan 5, 8:03 PM

This revision is now accepted and ready to land.Mon, Jan 5, 8:03 PM

pouria accepted this revision.Mon, Jan 5, 8:46 PM

nickbanks_netflix.com accepted this revision.Mon, Jan 5, 8:54 PM

Closed by commit rG21865c970888: tcp: Unifidef use of rss software hash in syncache (authored by gallatin). · Explain WhyMon, Jan 5, 8:58 PM

This revision was automatically updated to reflect the committed changes.

gallatin added a commit: rG21865c970888: tcp: Unifidef use of rss software hash in syncache.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_syncache.c

5 lines

Diff 169131

View Options

sys/netinet/tcp_syncache.c

tcp: Unifidef use of rss software hash in syncacheClosedPublicActions