Page MenuHomeFreeBSD

sndctl(8): Add libxo support
AcceptedPublic

Authored by christos on Dec 2 2025, 1:20 PM.
Tags
None
Referenced Files
F141652627: D54032.id167419.diff
Thu, Jan 8, 10:11 AM
Unknown Object (File)
Wed, Jan 7, 5:47 AM
Unknown Object (File)
Tue, Jan 6, 10:41 AM
Unknown Object (File)
Mon, Dec 29, 4:46 PM
Unknown Object (File)
Thu, Dec 18, 4:53 AM
Unknown Object (File)
Wed, Dec 17, 6:18 PM
Unknown Object (File)
Wed, Dec 17, 12:53 AM
Unknown Object (File)
Wed, Dec 17, 12:34 AM
Subscribers

Details

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69045
Build 65928: arc lint + arc unit

Event Timeline

christos created this revision.
usr.sbin/sndctl/sndctl.8
185–186

I think xo_options is really what's relevant to the reader of sndctl. That links to libxo(3) if they're curious.

usr.sbin/sndctl/sndctl.8
185–186

I followed what w(1) and wc(1)'s man pages say.

usr.sbin/sndctl/sndctl.8
185–186

I think it's wrong there too, but that isn't a good argument for why we should do it here.

What does the reader or soundctl might want to see also? xo_options explains how to actually use it.

usr.sbin/sndctl/sndctl.8
185–186

I think xo_options(7) is the reasonable think to refer to, since this isn't a programing manual about how the internals of sndctl(8) work, but how to use the utility with --libxo, which is explained in xo_options(7). This isn't wrong.

usr.sbin/sndctl/sndctl.8
185–186

That is what I am saying. You should link to xo_options(7). The diff is currently linking to libxo(3) instead.

christos marked 3 inline comments as done.

Refer to xo_options(7), not libxo(3).

usr.sbin/sndctl/sndctl.8
185–186

...Scratch that. I am an idiot. I thought you said the opposite, and I also thought the patch did the right thing.

usr.sbin/sndctl/sndctl.8
185–186

Actually it happens to everyone!

This revision is now accepted and ready to land.Dec 6 2025, 2:30 PM