bnxt: set hardware checksum only if required
AcceptedPublic
Actions

Authored by aurelien.cazuc.external_stormshield.eu on Thu, Nov 27, 10:32 AM.

Tags

Referenced Files

	Unknown Object (File)
	Sat, Dec 20, 2:38 AM

	Unknown Object (File)
	Fri, Dec 19, 11:20 AM

	Unknown Object (File)
	Mon, Dec 15, 6:27 PM

	Unknown Object (File)
	Thu, Dec 11, 9:20 AM

	Unknown Object (File)
	Mon, Dec 8, 11:03 PM

	Unknown Object (File)
	Mon, Dec 8, 9:36 AM

	Unknown Object (File)
	Tue, Dec 2, 9:13 PM

	Unknown Object (File)
	Sun, Nov 30, 9:18 PM

View All 17 Files

Subscribers

imp

Details

Reviewers

shurd
sreekanth.reddy_broadcom.com
tuexen

Group Reviewers

network

Summary

The test condition in the bnxt driver for TCP/UDP transmit hardware checksum offload is invalid: only the TCP / UDP csum bits should be tested
Only the relevant ipi_csum_flags bits are now tested as it's done in other iflib drivers

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

aurelien.cazuc.external_stormshield.eu created this revision.Thu, Nov 27, 10:32 AM

Herald added a reviewer: shurd. · View Herald TranscriptThu, Nov 27, 10:32 AM

Herald added a subscriber: imp. · View Herald Transcript

A branch on github is available here to ease merge: https://github.com/stormshield-acazuc/freebsd-src/tree/bnxt_csum

markj added a reviewer: sreekanth.reddy_broadcom.com.Thu, Nov 27, 2:25 PM

tuexen accepted this revision.Thu, Nov 27, 2:31 PM

This revision is now accepted and ready to land.Thu, Nov 27, 2:31 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

bnxt/

bnxt_en/

bnxt_txrx.c

22 lines

Diff 167172

View Options

sys/dev/bnxt/bnxt_en/bnxt_txrx.c

bnxt: set hardware checksum only if requiredAcceptedPublicActions