include.
ClosedPublic
Actions

Authored by skra on Feb 21 2016, 10:33 AM.

Details

Reviewers

kib
alc
jhibbits
cem

Group Reviewers

manpages

Commits

rS295880: As <machine/pmap.h> is included from <vm/pmap.h>, there is no need to

Summary

<machine/pmap> is included from <vm/pmap.h> so there is no need to include it explicitly when <vm/pmap.h> is already included.

Note that there are still files where <machine/pmap> is included solo.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

skra updated this revision to Diff 13560.Feb 21 2016, 10:33 AM

skra retitled this revision from to Remove redundant <machine/pmap.h> include..

skra updated this object.

skra edited the test plan for this revision. (Show Details)

skra added reviewers: alc, kib.

skra set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added reviewers: cem, jhibbits, manpages. · View Herald TranscriptFeb 21 2016, 10:33 AM

Herald added subscribers: rpokala, emaste, andrew, imp. · View Herald Transcript

kib accepted this revision.Feb 21 2016, 11:57 AM

kib edited edge metadata.

This revision is now accepted and ready to land.Feb 21 2016, 11:57 AM

alc accepted this revision.Feb 21 2016, 5:14 PM

alc edited edge metadata.

You might also check for cases where both <vm/vm_param.h> and <machine/vmparam.h> are included. This isn't nearly as common, but I have seen it.

Closed by commit rS295880: As <machine/pmap.h> is included from <vm/pmap.h>, there is no need to (authored by skra). · Explain WhyFeb 22 2016, 9:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

share/

man/

man9/

bios.9

1 line

sys/

amd64/

cloudabi64/

cloudabi64_sysvec.c

1 line

vmm/

amd/

npt.c

2 lines

svm.c

1 line

arm/

annapurna/

alpine/

alpine_machdep.c

1 line

arm/

mp_machdep.c

1 line

arm64/

minidump_machdep.c

1 line

cloudabi64/

cloudabi64_sysvec.c

1 line

compat/

linuxkpi/

common/

include/

linux/

dma-mapping.h

1 line

list.h

1 line

src/

linux_compat.c

1 line

linux_pci.c

1 line

dev/

ce/

if_ce.c

1 line

cp/

if_cp.c

1 line

drm/

drmP.h

1 line

drm2/

drmP.h

1 line

fb/

machfb.c

1 line

isci/

isci_oem_parameters.c

1 line

ntb/

if_ntb/

if_ntb.c

1 line

ntb_hw/

ntb_hw.c

1 line

pms/

freebsd/

driver/

ini/

src/

agtiapi.c

1 line

rt/

if_rt.c

1 line

siba/

siba_pcib.c

1 line

vt/

hw/

efifb/

efifb.c

1 line

i386/

bios/

mca_machdep.c

1 line

pci/

pci_cfgreg.c

1 line

mips/

adm5120/

admpci.c

1 line

atheros/

1 line

1 line

1 line

1 line

1 line

1 line

cavium/

cvmx_config.h

1 line

octopci.c

1 line

idt/

idtpci.c

1 line

malta/

gt_pci.c

1 line

mips/

minidump_machdep.c

1 line

nexus.c

1 line

nlm/

xlp_simplebus.c

1 line

rt305x/

rt305x_pci.c

1 line

sibyte/

sb_zbpci.c

1 line

powerpc/

aim/

slb.c

1 line

ofw/

ofw_real.c

1 line

rtas.c

1 line

powermac/

macgpio.c

1 line

macio.c

1 line

platform_powermac.c

1 line

powerpc/

genassym.c

1 line

trap.c

1 line

ps3/

1 line

1 line

1 line

1 line

1 line

1 line

pseries/

platform_chrp.c

1 line

psim/

iobus.c

1 line

sparc64/

pci/

fire.c

1 line

sparc64/

iommu.c

1 line

tlb.c

1 line

x86/

acpica/

acpi_wakeup.c

1 line

x86/

nexus.c

1 line

Diff 13600

View Options

head/share/man/man9/bios.9

View Options

head/sys/amd64/cloudabi64/cloudabi64_sysvec.c

View Options

head/sys/amd64/vmm/amd/npt.c

View Options

head/sys/amd64/vmm/amd/svm.c

View Options

head/sys/arm/annapurna/alpine/alpine_machdep.c

View Options

head/sys/arm/arm/mp_machdep.c

View Options

head/sys/arm64/arm64/minidump_machdep.c

View Options

head/sys/arm64/cloudabi64/cloudabi64_sysvec.c

View Options

head/sys/compat/linuxkpi/common/include/linux/dma-mapping.h

View Options

head/sys/compat/linuxkpi/common/include/linux/list.h

View Options

head/sys/compat/linuxkpi/common/src/linux_compat.c

View Options

head/sys/compat/linuxkpi/common/src/linux_pci.c

View Options

head/sys/dev/ce/if_ce.c

View Options

head/sys/dev/cp/if_cp.c

View Options

head/sys/dev/drm/drmP.h

View Options

head/sys/dev/drm2/drmP.h

View Options

head/sys/dev/fb/machfb.c

View Options

head/sys/dev/isci/isci_oem_parameters.c

View Options

head/sys/dev/ntb/if_ntb/if_ntb.c

View Options

head/sys/dev/ntb/ntb_hw/ntb_hw.c

View Options

head/sys/dev/pms/freebsd/driver/ini/src/agtiapi.c

View Options

head/sys/dev/rt/if_rt.c

View Options

head/sys/dev/siba/siba_pcib.c

View Options

head/sys/dev/vt/hw/efifb/efifb.c

View Options

head/sys/i386/bios/mca_machdep.c

View Options

head/sys/i386/pci/pci_cfgreg.c

View Options

head/sys/mips/adm5120/admpci.c

View Options

head/sys/mips/atheros/ar71xx_fixup.c

View Options

head/sys/mips/atheros/ar71xx_pci.c

View Options

head/sys/mips/atheros/ar71xx_spi.c

View Options

head/sys/mips/atheros/ar724x_pci.c

View Options

head/sys/mips/atheros/if_arge.c

View Options

head/sys/mips/atheros/qca955x_pci.c

View Options

head/sys/mips/cavium/cvmx_config.h

View Options

head/sys/mips/cavium/octopci.c

View Options

head/sys/mips/idt/idtpci.c

View Options

head/sys/mips/malta/gt_pci.c

View Options

head/sys/mips/mips/minidump_machdep.c

View Options

head/sys/mips/mips/nexus.c

View Options

head/sys/mips/nlm/xlp_simplebus.c

View Options

head/sys/mips/rt305x/rt305x_pci.c

View Options

head/sys/mips/sibyte/sb_zbpci.c

View Options

head/sys/powerpc/aim/slb.c

View Options

head/sys/powerpc/ofw/ofw_real.c

View Options

head/sys/powerpc/ofw/rtas.c

View Options

head/sys/powerpc/powermac/macgpio.c

View Options

head/sys/powerpc/powermac/macio.c

View Options

head/sys/powerpc/powermac/platform_powermac.c

View Options

head/sys/powerpc/powerpc/genassym.c

View Options

head/sys/powerpc/powerpc/trap.c

View Options

head/sys/powerpc/ps3/if_glc.c

View Options

head/sys/powerpc/ps3/platform_ps3.c

View Options

head/sys/powerpc/ps3/ps3_syscons.c

View Options

head/sys/powerpc/ps3/ps3bus.c

View Options

head/sys/powerpc/ps3/ps3cdrom.c

View Options

head/sys/powerpc/ps3/ps3disk.c

View Options

head/sys/powerpc/pseries/platform_chrp.c

View Options

head/sys/powerpc/psim/iobus.c

View Options

head/sys/sparc64/pci/fire.c

View Options

head/sys/sparc64/sparc64/iommu.c

View Options

head/sys/sparc64/sparc64/tlb.c

View Options

head/sys/x86/acpica/acpi_wakeup.c

View Options

Remove redundant <machine/pmap.h> include.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 13600

head/share/man/man9/bios.9

head/sys/amd64/cloudabi64/cloudabi64_sysvec.c

head/sys/amd64/vmm/amd/npt.c

head/sys/amd64/vmm/amd/svm.c

head/sys/arm/annapurna/alpine/alpine_machdep.c

head/sys/arm/arm/mp_machdep.c

head/sys/arm64/arm64/minidump_machdep.c

head/sys/arm64/cloudabi64/cloudabi64_sysvec.c

head/sys/compat/linuxkpi/common/include/linux/dma-mapping.h

head/sys/compat/linuxkpi/common/include/linux/list.h

head/sys/compat/linuxkpi/common/src/linux_compat.c

head/sys/compat/linuxkpi/common/src/linux_pci.c

head/sys/dev/ce/if_ce.c

head/sys/dev/cp/if_cp.c

head/sys/dev/drm/drmP.h

head/sys/dev/drm2/drmP.h

head/sys/dev/fb/machfb.c

head/sys/dev/isci/isci_oem_parameters.c

head/sys/dev/ntb/if_ntb/if_ntb.c

head/sys/dev/ntb/ntb_hw/ntb_hw.c

head/sys/dev/pms/freebsd/driver/ini/src/agtiapi.c

head/sys/dev/rt/if_rt.c

head/sys/dev/siba/siba_pcib.c

head/sys/dev/vt/hw/efifb/efifb.c

head/sys/i386/bios/mca_machdep.c

head/sys/i386/pci/pci_cfgreg.c

head/sys/mips/adm5120/admpci.c

head/sys/mips/atheros/ar71xx_fixup.c

head/sys/mips/atheros/ar71xx_pci.c

head/sys/mips/atheros/ar71xx_spi.c

head/sys/mips/atheros/ar724x_pci.c

head/sys/mips/atheros/if_arge.c

head/sys/mips/atheros/qca955x_pci.c

head/sys/mips/cavium/cvmx_config.h

head/sys/mips/cavium/octopci.c

head/sys/mips/idt/idtpci.c

head/sys/mips/malta/gt_pci.c

head/sys/mips/mips/minidump_machdep.c

head/sys/mips/mips/nexus.c

head/sys/mips/nlm/xlp_simplebus.c

head/sys/mips/rt305x/rt305x_pci.c

head/sys/mips/sibyte/sb_zbpci.c

head/sys/powerpc/aim/slb.c

head/sys/powerpc/ofw/ofw_real.c

head/sys/powerpc/ofw/rtas.c

head/sys/powerpc/powermac/macgpio.c

head/sys/powerpc/powermac/macio.c

head/sys/powerpc/powermac/platform_powermac.c

head/sys/powerpc/powerpc/genassym.c

head/sys/powerpc/powerpc/trap.c

head/sys/powerpc/ps3/if_glc.c

head/sys/powerpc/ps3/platform_ps3.c

head/sys/powerpc/ps3/ps3_syscons.c

head/sys/powerpc/ps3/ps3bus.c

head/sys/powerpc/ps3/ps3cdrom.c

head/sys/powerpc/ps3/ps3disk.c

head/sys/powerpc/pseries/platform_chrp.c

head/sys/powerpc/psim/iobus.c

head/sys/sparc64/pci/fire.c

head/sys/sparc64/sparc64/iommu.c

head/sys/sparc64/sparc64/tlb.c

head/sys/x86/acpica/acpi_wakeup.c

head/sys/x86/x86/nexus.c

Remove redundant <machine/pmap.h> include.
ClosedPublic
Actions

Revision Contents
Changeset List