openssh: Don't try to bind to unsupported addresses
ClosedPublic
Actions

Authored by des on Mon, Nov 3, 4:32 PM.

Details

Reviewers

emaste

Commits

rGe5ff8e797743: openssh: Don't try to bind to unsupported addresses

Summary

When selecting an address to bind to, skip IPv4 addresses if the kernel
does not support the inet feature, and IPv6 addresses if the kernel does
not support the inet6 feature.

PR: 195231

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Mon, Nov 3, 4:32 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Nov 3, 4:32 PM

des requested review of this revision.Mon, Nov 3, 4:32 PM

Harbormaster completed remote builds in B68386: Diff 165748.Mon, Nov 3, 4:32 PM

Is there a reason we can't go through upstream for this?

feature_present() is FreeBSD-only

With appropriate autoconf machinery then

I guess this is not too likely to result in a conflict in the future so OK, but would still prefer to loop through upstream.

This revision is now accepted and ready to land.Mon, Nov 3, 8:14 PM

Closed by commit rGe5ff8e797743: openssh: Don't try to bind to unsupported addresses (authored by des). · Explain WhyTue, Nov 4, 11:32 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGe5ff8e797743: openssh: Don't try to bind to unsupported addresses.

des added a reverting change: rG96e215ad8173: Revert "openssh: Don't try to bind to unsupported addresses".Tue, Nov 4, 8:16 PM

Revision Contents
Changeset List

Path

Size

crypto/

openssh/

sshconnect.c

6 lines

Diff 165801

View Options

crypto/openssh/sshconnect.c

openssh: Don't try to bind to unsupported addressesClosedPublicActions