Page MenuHomeFreeBSD
Differential D53233

sndctl(8): Modify vchans only on supported directions
ClosedPublic
Actions

Authored by christos on Oct 21 2025, 9:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 10, 11:13 AM
Unknown Object (File)
Tue, Dec 2, 10:31 AM
Unknown Object (File)
Thu, Nov 27, 2:55 PM
Unknown Object (File)
Tue, Nov 25, 3:37 PM
Unknown Object (File)
Tue, Nov 25, 8:55 AM
Unknown Object (File)
Sun, Nov 23, 6:46 PM
Unknown Object (File)
Thu, Nov 20, 4:18 PM
Unknown Object (File)
Thu, Nov 20, 1:28 AM
View All 29 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG470fae965fc2: sndctl(8): Modify vchans only on supported directions
rGe015e079f9db: sndctl(8): Modify vchans only on supported directions
rG70b34fbdbea1: sndctl(8): Modify vchans only on supported directions
Summary

Currently mod_play_vchans() and mod_rec_vchans() run unconditionally,
even if the direction (playback, recording) is not supported by the
device. This results in the "autoconv" (see mod_autoconv()) control
failing when run on simplex devices, because we'll be trying to modify
vchans on an unsupported direction.

Test whether the direction is supported and silently move on if it
isn't.

Sponsored by: The FreeBSD Foundation
MFC after: 4 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67950
Build 64833: arc lint + arc unit

Revision Contents
Changeset List

PathSize
usr.sbin/
sndctl/
4 lines

Diff 164679

View Options

usr.sbin/sndctl/sndctl.c

Loading...